mirror of
https://github.com/storytold/craft-libs.git
synced 2026-11-08 19:42:12 +00:00
Martin BallandClaude Opus 5.5
0675d58341
craft-libs#483 review (P2): English spelling checked the union of the three SCOWL dictionaries, so dialects crossed (en-US took colourblind, greyscale; en-GB took colorblind, esophagi). Each English now checks its own dictionary only. British English also takes the -ize spellings of its -ise words (SCOWL's en-GB is -ise only; Word accepts both), and en-variants.txt widens each dialect by its pairs; judgment/judgement come from craft-i18n#114, which CI now pins. English with no dialect (is_correct) still takes a word any English knows. Test: scowl_dialects_dont_cross samples the stems one dialect has and another lacks, for every pair. P3s: - English suggestions (a Tuning of their own): a missing space only between two lower-case words of three letters or more, ranked after every one-word candidate (publically: publicly first; no "Thea tr", "Che Que"), and no word the dictionary only capitalizes (Col, Wis) for a lower-case word. - A FORBIDDENWORD whole word is never rebuilt from compound parts. - to_bytes writes ONLYINCOMPOUND without compound rules too (round-trip test). - Failed lookups: the compound part table is filled lazily, and a word that doesn't start like a compound part (SCOWL: a digit) skips compounding; 20,000 failed long words take 83 ms, as without compounding (1.09 s before). - README: en-CA is not a British-spelling English. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FypgCX8LsYYE8fsj4byBm2
63 lines
2.3 KiB
YAML
63 lines
2.3 KiB
YAML
name: Proofing
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
paths: ["crates/proof/**", "Cargo.toml", "Cargo.lock", ".github/workflows/proof.yml"]
|
|
pull_request:
|
|
paths: ["crates/proof/**", "Cargo.toml", "Cargo.lock", ".github/workflows/proof.yml"]
|
|
workflow_dispatch:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
concurrency:
|
|
group: craft-proof-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
check:
|
|
timeout-minutes: 20
|
|
name: Proofing lint, tests with and without Language data, WASM
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
persist-credentials: false
|
|
# The Language data (craft-i18n `language-data/`), embedded by crates/proof/build.rs.
|
|
# Pinned to storytold/craft-i18n#114's head (#109's SCOWL dictionaries + judgment/judgement,
|
|
# CP2.1); TODO(CP2.1): move to #114's merge commit once it merges.
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
repository: storytold/craft-i18n
|
|
ref: c239f934ace90b7939afaceb23b472ceeafd6b8a
|
|
path: craft-i18n
|
|
persist-credentials: false
|
|
- uses: dtolnay/rust-toolchain@b725eda525362e7cf34af9a7243cac1e3f01a7ec # stable
|
|
with:
|
|
components: rustfmt, clippy
|
|
targets: wasm32-unknown-unknown
|
|
- uses: Swatinem/rust-cache@d1527c8f67ef9af357290475d4af4b0fab8f12e0 # v2.9.3
|
|
with:
|
|
key: craft-proof
|
|
- run: cargo fmt -p craft-proof --check
|
|
- name: Without Language data (a fork, docs.rs, offline)
|
|
run: |
|
|
cargo clippy -p craft-proof --all-targets --locked -- -D warnings
|
|
cargo test -p craft-proof --locked
|
|
cargo check -p craft-proof --locked --target wasm32-unknown-unknown
|
|
- name: A release without Language data fails
|
|
run: |
|
|
if CRAFT_I18N_REQUIRED=1 cargo check -p craft-proof --locked 2>build.log; then
|
|
echo "::error::CRAFT_I18N_REQUIRED=1 without CRAFT_I18N_DIR built"; exit 1
|
|
fi
|
|
grep -q "CRAFT_I18N_REQUIRED=1 but CRAFT_I18N_DIR is unset" build.log
|
|
- name: With Language data
|
|
env:
|
|
CRAFT_I18N_DIR: ${{ github.workspace }}/craft-i18n
|
|
CRAFT_I18N_REQUIRED: "1"
|
|
run: |
|
|
cargo clippy -p craft-proof --all-targets --locked -- -D warnings
|
|
cargo test -p craft-proof --locked
|
|
cargo check -p craft-proof --locked --target wasm32-unknown-unknown
|