Commit Graph
3503 Commits
Author SHA1 Message Date
Dylan M. Taylor 3f367fd710 Merge remote-tracking branch 'storytold/main' into feat/dex-reader 2026-11-18 09:17:09 -05:00
Dylan M. Taylor 7a7a18cb40 Merge pull request #2188 from chasse20/mcmat-v3
Publish MCMAT v3 as a portable procedural source archive
2026-11-18 08:32:32 -05:00
Dylan M. Taylor 74b198524b fix(zip): preserve named read error contracts 2026-11-18 07:47:03 -05:00
FredApps 06180c1a3f Merge pull request #2161 from FredApps/fix/786-psd-placement-parity
psd: preserve bounded placement and descriptor compatibility
2026-11-18 18:36:37 +07:00
Dylan M. Taylor abde74fa7d fix(mcmat): validate manifests and read resources by index 2026-11-18 06:33:33 -05:00
David Mann bc3cbc7edc Merge pull request #2142 from davidmann4/agents-live-client
MCP move shared code from PhotoCraft to craft-libs (#2141)
2026-11-18 12:19:07 +01:00
Dylan M. Taylor 486319f5ff fix(dex): retain reference-query parse incompleteness 2026-11-18 05:18:38 -05:00
FredApps e1fc4b1376 psd: annotate quilt policy test closure parameter 2026-11-18 10:39:08 +01:00
FredApps 01ffc9fbc7 Merge pull request #661 from wdunn001/craft-esign-upstream
craft-esign: e-sign contracts and the request-signatures dialog
2026-11-18 16:19:16 +07:00
FredApps 711bb1afcb Merge pull request #557 from totoz64/feat/french-language-pack-proofing
Proofing: add French pack rules and regional typography
2026-11-18 16:18:13 +07:00
FredApps d78a99a0a7 psd: validate explicit bounds in unsliced quilt context 2026-11-18 10:10:41 +01:00
FredApps c9862964df psd: require complete numeric explicit quilt bounds 2026-11-18 09:38:28 +01:00
FredApps e9ec481331 psd: preserve canonical quilt grids across numeric extremes 2026-11-18 09:11:45 +01:00
FredApps be556bedcb psd: align quilt serialization and strict slice admission 2026-11-18 08:43:10 +01:00
chasse20 b0f25d6418 Compress raw MCMAT source assets 2026-11-18 02:15:10 -05:00
FredApps b3960accde psd: reject invalid quilt bounds and discard unsupported templates 2026-11-18 08:08:01 +01:00
FredApps 14176282fd fix(dex): preserve decode completeness and fixture UTF-16 encoding (#2164) 2026-11-18 14:06:25 +07:00
Dylan M. Taylor 52fc6b5b3d Merge pull request #2054 from Bra1nZ/docx-package-element-budget
craft-docx: a package-wide XML element budget bounds hostile files' tree memory
2026-11-18 02:02:32 -05:00
Dylan M. Taylor 83d557741c Merge pull request #2060 from mmazzieri/rtf-page-field
craft-rtf: page fields show each page's number
2026-11-18 02:00:50 -05:00
Dylan M. Taylor a1ad315403 Merge pull request #2068 from storytold/feat/pkcs7-parsed-parts
PKCS7: expose consuming parsed certificate and revocation parts
2026-11-18 01:57:27 -05:00
Dylan M. Taylor 8c69881399 Merge pull request #2171 from storytold/fix/ps-token-budget
fix(ps): enforce decoded token limits on every encoded-string append
2026-11-18 01:56:34 -05:00
Dylan M. Taylor 70e562aa88 Merge pull request #2173 from storytold/fix/gltf-strict-uri
mesh: expose strict UTF-8 URI percent decoding
2026-11-18 01:56:03 -05:00
Dylan M. Taylor 221efe1b01 Merge pull request #2169 from storytold/fix/svg-token-private
fix(svg): reject malformed path tokens instead of truncating
2026-11-18 01:55:23 -05:00
chasse20 5ae0786c5b Publish MCMAT v3 as a bounded procedural source archive 2026-11-18 01:54:53 -05:00
FredApps 2dc55f4341 test(texture): make preserved golden float type explicit (#2131) 2026-11-18 13:35:40 +07:00
Dylan M. Taylor 1139798521 refactor(pkcs7): define certificate representations from one schema 2026-11-18 01:22:10 -05:00
Dylan M. Taylor 133b15453c fix(rtf): retain hidden-result and empty-field revision state 2026-11-18 01:21:44 -05:00
Dylan M. Taylor 4078682a51 mesh: expose strict UTF-8 URI percent decoding 2026-11-18 01:17:12 -05:00
Dylan M. Taylor e646d9307e fix(docx): charge rejected nested roots against shared element budget 2026-11-18 01:15:42 -05:00
Dylan M. Taylor 6811f1c2b1 fix(ps): bound every decoded string-token append 2026-11-18 01:03:27 -05:00
Dylan M. Taylor 6a18b99d6f fix(dex): report partial instruction decoding and encode fixture UTF-16 2026-11-18 01:01:37 -05:00
Dylan M. Taylor 172f5c78c7 fix(svg): reject malformed path tokens instead of truncating 2026-11-18 00:54:39 -05:00
Dylan M. Taylor 8bd0f08333 Merge pull request #1986 from Call4han/fix/xfl-overstated-directory-size
fix(xfl): read ZIPs with overstated central directory sizes
2026-11-18 00:36:44 -05:00
Dylan M. Taylor 9a5067d1b1 Merge pull request #1997 from dotCooCoo/fix/csv-sniff-separator-only-records
fix(csv): let rows of empty cells pick the delimiter when nothing else does
2026-11-18 00:36:30 -05:00
Dylan M. Taylor b6020ec2fc Merge pull request #2032 from r31lin/fix/preview-reader-non-zip
document-bundle: turn a non-zip file away after four bytes in read_preview_from
2026-11-18 00:00:13 -05:00
FredApps f8d869c1e7 psd: preserve bounded placement and descriptor compatibility 2026-11-18 05:41:30 +01:00
FredAppsandFredApps 50fbf2bd0c testkit: share exact format mutation corpus across DEX WASM and TAR (#2106)
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
2026-11-18 11:07:00 +07:00
William Dunn ec65838487 craft-suite-account: provider-neutral suite account list and keychain token store (#665)
* craft-suite-account: the suite account list and keychain token store

Carries crates/suite-account over from the cut-down craft-libs#160 branch. This follows RFC-0025 (storytold/craft-contrib#35).

service.rs is removed. It was the CollabCraft device-flow client. Its Service, Flow, Identity, Polled and SignedOut types went with it. Store::sign_out is also gone. The provider adapter now owns ending a session at the deployment. Store::discard and Store::forget cover the local half that stays here.

Every remaining CollabCraft-specific word is reworded to a provider-neutral description. The one serde alias and the one test fixture name that spelled the old provider out are gone too.

Adds a generation field to Account, per RFC-0025's cross-app lifecycle guarantees. A sign-in bumps it. Store::update_token refuses a write made against a stale generation. A fuller tombstone for the removal case is left as a TODO referencing the RFC, documented on Accounts::remove.

Also drops one unused restrict() function found while verifying clippy -D warnings on Linux. It was pre-existing dead code. The unix write path already sets the file mode at creation.

* craft-suite-account: lock list mutations, make generations monotonic across removal

Fixes the three review gates on PR #665 (rev 2e9c84f).

Every mutation of accounts.json now goes through an OS-level file lock. The
lock is a sibling .lock file taken with std::fs::File::try_lock and a
bounded retry, matching the mechanism craft-ai-integrations' store already
uses for the same problem. Two processes each completing 100 sign-ins into
one folder used to leave 101 rows on file. Both the real two-process and
two-thread conformance tests now land all 200 rows.

A removed account now leaves a tombstone holding its last generation. A
re-add continues past that tombstone. It never restarts at 0.

update_token checks the generation twice. The first check runs before the
keychain is touched at all. An already-stale caller never overwrites a
newer token. The second check runs under the lock, after the keychain
write. It catches a removal that landed in the window that write opened. A
tombstoned account answers StaleGeneration. It never answers Unknown. The
second check also removes the token it just wrote, under the same lock,
when the account turns out to be gone. A refresh racing a discard can then
resurrect neither the row nor the keychain entry. discard itself now
removes the keychain entry inside the same lock hold as the list write.

The module docs now name the chosen keychain-versus-list write order for
each operation. They also name the state a crash in that window leaves
behind for the next reader to repair, per RFC-0025 guarantee 1. A new test
simulates the window update_token opens between its keychain write and its
generation commit.

The conformance tests are adapted from the maintainer's review-reproduction
gist for this crate. Forget racing a refresh is the one gist case left out.
forget is deliberately generation-agnostic and local, per RFC-0025
guarantee 4. That fix would be a separate, broader change than these three
gates.

* craft-suite-account: close the review gaps CodeRabbit found in the rebase

Six fixes. Generation bumps in sign_in, update_token and remove_with_tombstone
now use checked_add. A bump at the maximum refuses with GenerationExhausted.
It never wraps back to a small number a stale caller could pass again.
accounts::write now refuses a list that would serialize
past MAX_BYTES before touching disk. An oversized display name can then
never brick the list for every later reader. NewAccount.linked now persists
onto Account. It used to be silently dropped at sign_in. update_token's
stale-write cleanup now only removes a keychain token that still matches the
token it wrote itself. A concurrent sign-in's token for the same handle
survives that cleanup now. Store::forget and Store::has_token now return
Error::Isolated before touching the keychain, matching every other mutator.
migrate::adopt re-reads the legacy file right before deleting it and skips
the delete when something rewrote it since. The read buffers are wrapped in
Zeroizing too. A parsed-but-unused token copy no longer outlives the one
Secret already covers.

Three findings were not valid against this code and are not changed. The
torn-state window CodeRabbit flagged in update_token's generation commit is
the same crash recovery the module docs already describe. The existing
torn-state test already exercises it. Forcing the keychain write under the
same lock as two concurrent sign-ins for one handle would reintroduce the
cross-process deadlock the lock module exists to avoid. A failed discard
already reports its own error. A refresh that re-establishes a full session
afterward is recovery. It is never a silent mismatch.

* craft-suite-account: apply cargo fmt to the review-gap fixes

cargo fmt wraps the long struct literals and assert calls the previous
commit added. The content is unchanged.

* craft-suite-account: factor the race test's join-handle type out

clippy::type_complexity flagged the four-deep generic on handle_slot in the
stale-refresh-vs-re-sign-in test. A type alias clears it without changing
the test.

* craft-suite-account: flush before the rename, re-check the token under the lock

Two review findings. The temporary file is now flushed with sync_all before the rename, keeping the crash story the doc tells. A discard racing a sign-in could delete the token the sign-in had just written and the sign-in still reported Ok. The lock closure re-checks the keychain right before committing the row and writes the token again when something else changed it.

* craft-suite-account: sync the parent directory after the rename

The temp-file flush persists the bytes. The rename changes a directory entry with its own durability on Linux. Power loss after write returned could otherwise resurrect the older list and lose a tombstone a discard already reported written. A sync failure now reports an error, never success. Unix only, since directories do not open for sync elsewhere.

* craft-suite-account: keep activation out of refresh, require an explicit format marker, stop logging paths

Three fixes. update_token no longer calls Accounts::put for its row commit.
That call always makes the written row active. Refreshing an account in
the background used to silently steal the selection from whatever account
the person had actually picked. A new Accounts::refresh_in_place replaces
the row without touching active. put stays exactly as it was for sign_in
and set_active, the two calls meant to change it.

Accounts::format no longer carries #[serde(default)]. Every other field
still does. A missing format key used to default through Accounts's own
Default impl. That impl answers FORMAT. A file that never declared a
format therefore read as exactly the one format this build understands.
read now also rejects any parsed format that is not exactly FORMAT. The
old check only rejected a newer one; format 0 passed it the same way a
missing key did.

accounts::read's error messages now name only the file, never the full
path. Store::shared logs a read failure at warn. The path sits under the
user's profile folder.

restrict on Windows stays a no-op. Its comment now states the guarantee's
real scope. The default per-user config folder gives it. A portable
install or an ARTCRAFT_SUITE_DIR override does not. A real fix needs the
Win32 authorization API. Every binding for it is an unsafe fn. This
workspace forbids unsafe_code outright. That part of the finding is
refused in part. Closing it for real needs a maintainer-approved exception
for this one call site, or a vetted dependency wrapping that API safely.
Either is a decision for its own PR.

* craft-suite-account: move update_token's keychain write inside the lock

skylartaylor's finding. update_token used to write the keychain, then take
the list lock. A newer sign-in, or a discard followed by a re-add, could
land for the same handle in between. The second check under the lock
already answered StaleGeneration in that case, but the earlier write had
already landed over the newer session's token. shared() then served the
new session's row with the stale refresh's bytes. Deleting the stale token
on its own was never going to fix this; that still loses the newer
session, it only changes which bytes go missing.

The keychain write now happens only inside the lock, in the second
generation check's own success arm, immediately before the row commits.
The first, unlocked check still exists, purely to reject an already-stale
caller before it ever takes the lock; it writes nothing. Every losing
path, a newer sign-in, a discard, a discard followed by a re-add, now
answers with an error having never touched the keychain at all. There is
nothing stale left in it to clean up or weigh against a winner's own
token. Store::remove_token_if_still is gone. Its two call sites in the
losing branches never write a token to begin with now. Nothing is left
for it to conditionally remove.

This keeps the lock discipline the module docs describe: the write is
conditional on the row commit going ahead, the same shape as discard's own
keychain call inside its lock hold and sign_in's existing re-check, never
an unconditional call made regardless.

Two deterministic tests reproduce both orderings skylartaylor named, each
proving the fix against the pre-fix code before passing against the fix:
a_refresh_racing_a_newer_sign_in_for_the_same_handle_never_overwrites_its_token
and a_refresh_racing_a_discard_and_re_add_for_the_same_handle_never_overwrites_its_token.
Both hold the real accounts lock on a background thread standing in for
the winning operation. They release it only after the refresh's own
unlocked first check has had the chance to read the pre-race state. Both
then assert shared() serves the winning session's own token afterward.

The crate's own pre-existing hook-based race tests could no longer reach
the window they were built for, since that window no longer has a
keychain call in it to hook. tests/review_repro.rs's two Hooked-based
tests are rewritten onto real threads racing on a Barrier instead, the
same device the file's own two-thread sign-in test already uses. The lock
makes their outcomes hold for either ordering now. A hook could only ever
force one. The now-unused Hooked harness is removed along with them.
src/tests.rs's own matching hook-based test is replaced outright by the
two new ones above. That covers its ground and the newly found gap
together.

* craft-suite-account: pin the race tests' second-check window

skylartaylor's review note on PR 665: the two update_token race tests in
src/tests.rs send their release signal and then immediately call
update_token, so the competing sign-in or discard-and-re-add can finish
before the refresh's first, unlocked check ever runs. A pre-fix build
could then pass the same assertions by rejecting early at that first
check, never reaching the second, locked one the tests are named for.

Adds race_hook, a test-only pause point inside update_token between its
two checks. A test arms it, starts the refresh, waits for the refresh to
signal that its first check has read the pre-race generation, runs the
competing operation to completion, then releases the refresh into its
second check. Both race tests are rewritten onto this instead of holding
the real accounts lock on a background thread, which left the same gap
skylartaylor found: the lock never blocked the refresh's unlocked first
read, only its second, locked one.

* craft-suite-account: make the race test hook per store instead of process wide

CI runs this crate's suite with the default, parallel test runner. The
hook update_token pauses on between its two generation checks lived
behind one process wide slot, so when the Workspace gate's parallel run
landed both race tests at the same time, one test's release on that
slot answered the other test's pause: the pinned ordering collapsed,
the refresh ran ahead of the competing write, its second check legitimately
matched, and update_token returned Ok where the test expected
StaleGeneration. Reproduced on the lab build host with the crate's
default threaded test run; failed on the first attempt, matching the
CI failure exactly.

The hook now lives on the Store instance, one per store, armed only on
the exact store a given test built. A concurrent test's own store keeps
its own hook, so there is nothing left for two tests to cross no matter
how the runner schedules them. Checked the rest of the suite for the
same kind of shared state: every other test builds its own tempdir and
its own in-memory keychain, and the two-process test spawns its own
child with --test-threads=1 for that child's own run, so none of them
depend on the parent suite running single threaded.
2026-11-17 21:56:16 -06:00
Dylan M. Taylor 71579152ff Separate strict native preview sniffing from generic ZIP compatibility 2026-11-17 22:46:28 -05:00
FredApps 7d06803a32 fix(doc-binary): use canonical MD4 BLIP identifiers (#2153) 2026-11-18 10:41:59 +07:00
batistalucasv c0edd96888 craft-html, craft-flow: preserve table structure, colgroup widths and vertical merges (#1785) (#1802)
* craft-html, craft-flow: preserve table structure, colgroup widths and vertical merges (#1785)

* craft-html: address CodeRabbit review feedback on vmerge and colgroups (#1785)

* craft-html: precompute grid column offsets in table export

* craft-html: preserve fully covered rows during table import (#1785)

* craft-html: resolve merge conflict artifacts and unclosed delimiter in tests (#1785)

* craft-flow, craft-html: validate matching spans on vmerge and preserve leading grid columns (#1785)
2026-11-17 21:31:10 -06:00
FredApps a7d537d596 Merge current main while preserving dex extraction and safety repair 2026-11-18 03:29:26 +01:00
David Mann 6b16ec2b41 craft-control agents: second review round (#2141)
- The token is passed on as the app wrote it (trimmed): craft-control's
  server compares exactly and accepts any CONTROL_TOKEN of 32+ chars.
  The token file is checked as a regular file before it is opened (a
  FIFO would block the open).
- Allow Agent Control off counts as not allowed on the CLI's side too.
- A window route is dropped once no app accepts agents.
- A headless session with the app's agent folders ends when the person
  stops letting agents in.
- The launch timeout is capped and the deadline computed without
  overflow; the poll interval is kept between 1 ms and 1 s.
- The connect error names the app's window; the guide says to remove
  the connection file on quit and that one process per settings folder
  accepts agents; the AppImage mount is compared after resolving links.
- Tests for each, and a wider margin in the queued-start test.
2026-11-18 03:19:07 +01:00
FredAppsandFredApps 5b1ad7511c dex: bound retained reference caller and target strings (#2115)
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
2026-11-18 09:17:21 +07:00
FredApps c52dc70c6c Merge pull request #2083 from FredApps/test/mxf-hostile-scheduling-778
test(media): schedule MXF hostile seeds independently
2026-11-18 09:15:30 +07:00
FredApps 7b8c1eccea Merge pull request #2041 from Terra854/codex/svg-integrity-hooks-review21
Share checked SVG image validation and DOM reuse
2026-11-18 09:15:11 +07:00
William Dunn bfe246b5b4 craft-ui: leave the menu module ungated, as main has it
This branch gated `pub mod menu;` behind the esign feature, which was right when main had no menu module of its own. #160 landed one, and its cloud pages use it (crates/ui/src/cloud/pages.rs, cloud/title.rs). The gate therefore broke every build with cloud on and esign off, which is what the workspace clippy leg does. The gate was the whole remaining content of the commit that carried the helper across.
2026-11-17 21:04:35 -05:00
William Dunn a64ad59593 craft-esign make the outstanding-send regression test actually outstanding
The send helper submitted the create immediately, consuming the captured context before the status request ran. The test now queues and takes document A's send without submitting it, leaving the context pending. That pending context is the scenario the guard exists for.
2026-11-17 21:03:40 -05:00
William Dunn 52d874ae96 craft-esign keep the send context off status requests
submit_request consumed the captured send context for every request kind. A status refresh for the current document submitted while another document's send was still outstanding then carried the old context. pump dropped its reply as stale. The context now goes only to the create submission that answers the taken send request. Every other request uses the current context.
2026-11-17 21:03:40 -05:00
William Dunn df8f35d297 craft-esign apply rustfmt to the refresh caption test
Wraps a line fmt would otherwise reject on the next check.
2026-11-17 21:03:40 -05:00