mirror of
https://github.com/storytold/craft-libs.git
synced 2026-11-10 20:42:12 +00:00
CP2.2: review — each English checks only its own SCOWL dictionary; English suggestions drop junk splits and names
craft-libs#483 review (P2): English spelling checked the union of the three SCOWL dictionaries, so dialects crossed (en-US took colourblind, greyscale; en-GB took colorblind, esophagi). Each English now checks its own dictionary only. British English also takes the -ize spellings of its -ise words (SCOWL's en-GB is -ise only; Word accepts both), and en-variants.txt widens each dialect by its pairs; judgment/judgement come from craft-i18n#114, which CI now pins. English with no dialect (is_correct) still takes a word any English knows. Test: scowl_dialects_dont_cross samples the stems one dialect has and another lacks, for every pair. P3s: - English suggestions (a Tuning of their own): a missing space only between two lower-case words of three letters or more, ranked after every one-word candidate (publically: publicly first; no "Thea tr", "Che Que"), and no word the dictionary only capitalizes (Col, Wis) for a lower-case word. - A FORBIDDENWORD whole word is never rebuilt from compound parts. - to_bytes writes ONLYINCOMPOUND without compound rules too (round-trip test). - Failed lookups: the compound part table is filled lazily, and a word that doesn't start like a compound part (SCOWL: a digit) skips compounding; 20,000 failed long words take 83 ms, as without compounding (1.09 s before). - README: en-CA is not a British-spelling English. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FypgCX8LsYYE8fsj4byBm2
This commit is contained in:
1 parent
e6e948f7d5
commit
0675d58341
8 files changed
+265
-69
No files matched your search
@@ -25,11 +25,12 @@ jobs:
|
||||
with:
|
||||
persist-credentials: false
|
||||
# The Language data (craft-i18n `language-data/`), embedded by crates/proof/build.rs.
|
||||
# Pinned to storytold/craft-i18n#109's merge commit (the SCOWL dictionaries, CP2.1).
|
||||
# Pinned to storytold/craft-i18n#114's head (#109's SCOWL dictionaries + judgment/judgement,
|
||||
# CP2.1); TODO(CP2.1): move to #114's merge commit once it merges.
|
||||
- uses: actions/checkout@v4
|
||||
with:
|
||||
repository: storytold/craft-i18n
|
||||
ref: efb1127ac65b238ccfe7df1893f33e91b924b96e
|
||||
ref: c239f934ace90b7939afaceb23b472ceeafd6b8a
|
||||
path: craft-i18n
|
||||
persist-credentials: false
|
||||
- uses: dtolnay/rust-toolchain@b725eda525362e7cf34af9a7243cac1e3f01a7ec # stable
|
||||
|
||||
Reference in new issue
Block a user