mirror of
https://github.com/storytold/craft-launcher.git
synced 2026-11-16 23:24:31 +00:00
* Match MSI entries and find app executables through pure functions Windows detection decided which uninstall entry belongs to an app, and which paths might hold its exe, inline in the registry-reading code under #[cfg(windows)]. Neither decision needs the registry or the disk, so move both into module-level functions, is_installer_entry and exe_candidates, that tests can call on every platform. The windows module keeps the registry reads and the exists() checks. No behaviour change: an entry still has to carry the app's display name and the Learning Machines LLC publisher, exactly, and the candidates are the same paths in the same order. The new tests pin that down for every app but PdfCraft, and for PdfCraft's own entry name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Detect PdfCraft installs made by its PrintCraft-named MSI PdfCraft's Windows installer shipped as PrintCraft up to 0.2.1 (printcraft-0.2.1-windows-x64.msi). That MSI registers its uninstall entry with DisplayName "PrintCraft" and installs printcraft.exe into Program Files\PrintCraft, but Windows detection only accepted an entry named after the app's current name and looked only for pdfcraft.exe, in App Paths, the install folder and Program Files\PdfCraft. On a machine still on that install the launcher showed PdfCraft as not installed, with no version, and uninstall_msi found nothing to remove. The catalog already knows the old asset stem (former_ids); add former_names for the display names an app's installers registered, since the capitalisation can't be derived from the stem, and names() to go with stems(). Entry matching now accepts any of the app's names, still exactly and still only from Learning Machines LLC, and the exe is looked up under every stem in App Paths and under every name in Program Files, current first. Apps without former names see the same match and the same candidates as before. The impact is limited to early adopters: PdfCraft 0.4.0 and later register as PdfCraft, and their MSI keeps the same UpgradeCode, so installing from the launcher already upgraded a PrintCraft install in place. What this fixes is the wrong status and the missing Uninstall until then. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Brandon Thomas <echelon@gmail.com>