mirror of
https://github.com/storytold/craft-launcher.git
synced 2026-11-16 15:14:56 +00:00
Split out of #640 at review request: a translation PR is the wrong place for a process-handling change. ## What When the direct child exits while a captured reader is still unfinished — a descendant holding a pipe, or output still being drained — `run_command_with_output` waits for the readers under the same deadline. On timeout the error said `<program> didn't finish within N seconds`, although the child had finished. It now says `<program> exited, but its output was still being captured at the N second deadline`, which names the shared deadline and does not claim the pipe is still open (`20026ee`). In `inherited_pipe_tests`, an attempt whose direct child hit its own deadline before the holder filled both pipes proves nothing about inherited pipes, so the test retries it with a longer deadline, as it already did for an attempt that never reached the marker. The retry ceiling is a named `MAX_DEADLINE`. ## Testing Run locally on Linux x86_64: `cargo test -p artcraft-launcher-native inherited_pipe_tests` passes (1 passed, 2 ignored fixtures), `cargo clippy -p artcraft-launcher-native --all-targets --locked -- -D warnings` is clean, and `cargo fmt --all -- --check` is clean. The wasm check was not run because this crate is not part of the web build. Hosted CI is left to run.