Commit Graph
14 Commits
Author SHA1 Message Date
JeremyandClaude Opus 5.5 1167239dfe feat(versions): every app the launcher opens is told where the version choices are
Only tarball apps on Linux were given CRAFT_VERSIONS_FILE. Now every launch
route passes it: Windows (exe and MSI) and AppImages through the process
environment, Flatpak apps through `flatpak run --env=`, and anything the
Flatpak launcher starts on the host through `flatpak-spawn --env=`. macOS
apps open through Launch Services with the real home, so they find the file
at its default path; `open` is left unchanged since not every macOS version
takes an environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 13:00:55 +00:00
803d5f57a4 fix(windows): launch system helpers by absolute path (#815)
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
2026-10-24 01:44:10 -04:00
Dylan M. TaylorandCodebuff 674b893f0e Refactor the complex fns, expand wildcard imports, tidy closures and lifetimes (SonarCloud) (#836)
* Refactor the complex fns, expand wildcard imports, tidy closures and lifetimes (SonarCloud)

- S3776: split the twelve flagged functions (portable install, backend check
  sweep, app details drawer/hero/identity, toolbar and its banner rows, table
  header/rows/cells, action menu and its phases, settings install panels,
  widgets cells, narrow-header test) into focused helpers
- S2208: replace the nine `use super::*` in platform test modules with the
  exact imports each module needs
- S1612: call clone() on the iterator directly instead of in a closure
- S8833: drop the redundant reference in iterator-based loops
- shellcheck: use [[ ]] division guard in packaging/linux/package.sh

* Lint: pass a fixed printf format to sha256sum, not a variable (shellcheck SC2059)

The shellcheck gate flags printf with a variable format string; inline
'%s  %s' at the four sha256 check sites so the format is a literal. No
behavior change.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>

* Fix: a Windows build needs CraftApp in the windows module's scope

uninstall_msi references CraftApp but the module's super import omitted
it, breaking the Windows clippy job only (caught by CI, not by the
Linux check the branch was verified with).

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>

* Address the CodeRabbit review: no missing-entry assert, and the paused
row's resume button measures against the full row width again

- details: return early when the shown detail has no matching entry
  (non-test code never panics); the assert only fired in debug builds
- actions_in: paused_actions gets the full row width, as the branch
  subtracted the discard and menu buttons from it itself; passing
  main_w sized the resume button one CONTROL_H + gap too narrow

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>

---------

Co-authored-by: Codebuff <noreply@codebuff.com>
2026-10-23 17:14:44 -04:00
dotCooCoo bf16e21f76 fix(windows): self-update runs no PowerShell and installs only files signed like the launcher
On Windows the launcher finished its own update with a detached
powershell.exe started with -ExecutionPolicy Bypass -WindowStyle Hidden.
The script waited for the launcher to exit, ran the new MSI or unpacked
the portable zip with Expand-Archive, deleted the download and started the
new exe. Antivirus heuristics score that sequence, and the command line
sits in the signed exe as a string.

The update helper is now a copy of the launcher itself, put in
<cache>\launcher-update-helper and started with --finish-update. It waits
for the old process with OpenProcess and WaitForSingleObject (winsafe),
runs msiexec /i /passive /norestart and checks its exit code, or unpacks
the portable zip with the checks portable app installs already use, and
then starts the launcher again. main() hands --finish-update to the helper
before logging, the single-instance claim and the window.

The helper finishes only the launcher's own update:
- the exe is this launcher's MSI or portable installation, and the
  helper, the download and the staging folder are in that installation's
  cache;
- the MSI, every program in the portable zip and the exe it starts carry
  a valid Authenticode signature from the helper's own publisher
  (verifysign, through WinTrust).
The launcher checks its own signature, the installed exe and the new MSI
before it quits, so an unsigned build reports that it doesn't install
updates instead of closing. A failed update clears the self-update marker,
so the next check offers it again, and the next start logs the error.
2026-10-21 12:07:47 -07:00
Brandon ThomasandClaude Opus 5.5 7e6460e5c8 fix(freebsd): install the aarch64 tarball on FreeBSD aarch64 and steady the pipe-deadline test
Craft App releases ship <app>-<ver>-freebsd-aarch64.tar.gz next to the
x86_64 tarball, but the platform tokens had none for FreeBSD on ARM64, so
nothing was picked there and the backend's kept-download tests failed on
the nightly FreeBSD aarch64 job. Pick freebsd-aarch64 on FreeBSD ARM64 the
way freebsd-x86_64 is picked on x86_64 (no cross-arch fallback), with a
core test on SoundCraft v0.10.0's release metadata trimmed to its FreeBSD
tarballs, and add the token to the backend tests' synthetic release.

The inherited-pipe test gave its direct child one second to start a second
test process and fill both pipes; under emulation that takes longer, so
run() killed the child first and the test never reached the case it
checks. Retry with a longer deadline (1 s, 4 s, 16 s) when the child didn't
get that far, let the descendant hold the pipes for 120 s unless stopped,
and still require run() to return within twice its deadline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-20 10:53:56 -04:00
Mexandskylar taylor-barrick c08e5f5d4e Drain helper output after reaching the capture limit (#315)
* Drain helper output after reaching the capture limit

* fix: enforce helper deadline while draining inherited pipes

Keep both reader completions under the original shared timeout after the direct child exits. Add a finite self-spawned descendant regression that fails before the fix. Fresh isolated module: 6 tests passed, 2 ignored fixture entry points; strict Clippy and formatting passed. Independent review approved. Timeout detaches readers as before; no descendant-tree cancellation or lifetime resource-cleanup claim. AI assistance: OpenAI Codex for @MMexicann.

---------

Co-authored-by: skylar taylor-barrick <hi@skylar.cc>
2026-10-17 22:02:43 -06:00
Dylan M. Taylor e85a296426 Open the Discord app for Discord links when it's installed (#566)
Detect a registered discord:// handler in the background and fall back to https://discord.gg/artcraft when the deep link can't be opened.
2026-10-17 20:03:55 -06:00
307efcf45a feat(install): choose where Craft apps are installed (#461)
* feat(install): choose where Craft apps are installed

Settings gets a default install folder, and a fresh install asks for the
app's folder (prefilled with the default). Updates stay beside the copy
they replace. Works for MSI (INSTALLFOLDER), DMG bundles, and AppImages;
on Linux a custom folder means AppImage. Flatpak and the web build keep
the system location and skip the prompt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(windows): integrate portable installs with custom locations

* fix(install): ask before writing over something already in the install folder

Staging used a predictable `.<name>.partial` path beside the destination, so a
file the user kept under that name could be overwritten (AppImage) or deleted
(macOS). Stage in a fresh private folder instead.

A new install whose destination already exists now stops before downloading
and asks "Replace what's there?". Replace installs over it: the AppImage or
.app is swapped in, a portable install writes over same-named files only, and
the MSI installs into the existing folder. Cancel leaves everything as it was.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(install): a planted .partial symlink can't redirect AppImage staging

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Skyfuller1303 <skyfullerdesign@gmail.com>
2026-10-15 20:46:32 -06:00
BFlatandClaude Opus 5.5 c1a9b36f82 macOS: open disk images reliably, and say why when they won't open; 0.2.1 (#135)
* macOS: open disk images reliably, and say why when they won't open

Installing or updating an app on macOS could fail with only "couldn't open
the disk image". hdiutil's own reason was thrown away, and every install of
an app mounted its image at the same folder, which an attach that was
interrupted or timed out could still be holding.

- Each install mounts its image at a new, empty folder.
- The attach skips hdiutil's checksum pass (-noverify): the download's
  SHA-256 is already checked against the release, and on a large image that
  pass alone could run past the time limit, now 5 minutes.
- When the image still won't open, or the app won't copy, the message says
  why in hdiutil's or ditto's words ("couldn't open the disk image:
  Resource temporarily unavailable").
- hdiutil, ditto and codesign are run by full path: a launcher started from
  Finder or at login gets a minimal PATH.

process::run is capture's sibling that returns the helper's error message;
capture is now built on it. The launcher's own macOS self-update installs
through the same code, so it gets all of this too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Release 0.2.1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-11 19:51:54 +07:00
5b7d4781f5 Windows: fix "Show in Explorer" opening Documents instead of the app's folder (#54)
* Fix Show in Explorer opening Documents for paths with spaces

reveal() built `/select,<path>` as one argument and passed it with
Command::arg, which quotes any argument containing a space. The Craft
apps' MSIs install under C:\Program Files, so Explorer received
"/select,C:\Program Files\...\app.exe", didn't recognise the switch and
opened its default folder, Documents.

The argument is now `/select,"<path>"`, with only the path quoted and
forward slashes turned into backslashes, passed with raw_arg so Rust
leaves it alone. The argument building is a plain function with unit
tests that run on every platform.

Fixes #39

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Refuse a path with a quote in it; give the Explorer tests their own module

A " would end the quoted /select path early and pass the rest to Explorer as
switches. The module name clashed with the pgrep tests that landed in #81.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Fabio Lussi <198260595+itrycodinganditsbad@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
2026-10-11 03:59:59 -04:00
Dylan M. Taylor 28ef3ad924 Linux: prefer the launcher's own format (Flatpak, AppImage) and run host apps from the Flatpak sandbox (#89)
* linux: prefer Flatpak if available and support Flatpak sandbox execution

* linux: match default package format to launcher format (Flatpak for Flatpak, AppImage for AppImage)

* ui: default package preference selection to launcher format (Flatpak for Flatpak, AppImage for AppImage)
2026-10-11 02:21:10 -04:00
Benziza 9eb2c60f18 Match running app paths literally (#81) 2026-10-11 02:18:20 -04:00
Dylan M. Taylor 797071e591 Linux: fix detection of system package installs (#99)
- Include InstallSource::Rpm in ours package filter
- Add bundle_id to candidate names for Deb and Rpm packages
- Strip architecture suffix from package name in parse_dpkg
- Clear AppImage environment variables in process::command to prevent polluting system tools
- Fall back to detecting system desktop entries and binaries with CLI version extraction
- Add unit tests for candidate names, RPM filtering, and binary CLI version

Fixes #97
2026-10-11 02:10:53 -04:00
Brandon ThomasandClaude Opus 5.5 ec69f0be2c ArtCraft Launcher: install and update the Craft App Suite
A native Rust/egui launcher for the 12 Craft Apps (7 classic + 5 new).

- Grid (icon cards) or sortable table view, filters and search
- Status per app: available, installed and up to date, or update
  available with version and release date
- Installs where each OS keeps apps, from the official release packages:
  /Applications (DMG), Program Files (MSI), deb/rpm via the system
  package manager (Flatpak/AppImage fallback), /usr/local on FreeBSD
- Detects apps installed by hand; updates keep the installed format
- Every download verified against its published SHA-256; running apps
  are never replaced
- Tray/menu-bar mode, start at login, one notification per new version
- GitHub API with ETag cache, falling back to release pages when
  rate-limited; release source is pluggable for a future catalog API
- Web build lists latest releases with per-platform downloads
- Packaging and release workflows for macOS, Windows (x64/x86/arm64),
  Linux (x86_64/aarch64), FreeBSD and web

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-09 21:08:24 -04:00