Commit Graph
92 Commits
Author SHA1 Message Date
Dylan M. Taylor e78816ca65 ci: install WebKitGTK for Sonar coverage builds 2026-11-04 10:00:47 -05:00
Dylan M. Taylor d43ee91f82 ci: install libsoup for Sonar coverage builds 2026-11-04 09:56:06 -05:00
Dylan M. Taylor 7987c57447 ci: prefer org SonarCloud PAT 2026-11-04 09:53:55 -05:00
Kristian Myram 4b2457cec2 Merge main and resolve workflow test trigger conflicts 2026-11-03 12:30:26 +00:00
Dylan M. Taylor f76b6b82d2 Fix Linux signing rollout and review findings 2026-11-03 00:00:15 -05:00
Dylan M. Taylor 4da08b882e Merge pull request #98 from g1obalworlds/ci/run-tests-for-every-tested-file
ci: run the unit tests when any workflow or action they cover changes
2026-11-02 22:29:15 -05:00
Dylan M. Taylor 96b8516a40 feat(release): sign every Linux package format with LINUX_SIGNING_KEY
A new optional LINUX_SIGNING_KEY secret (an unprotected OpenPGP signing subkey, from the
release environment) signs each Linux format the way its tools check it:

- rpm: embedded signature (rpmsign), for `rpm -K` and dnf/zypper gpgcheck
- deb: embedded _gpgorigin member (debsigs) and a detached .asc
- Arch: <file>.sig, which pacman looks for
- AppImage, tar.gz, zsync: detached .asc
- Flatpak bundle: signed commit and embedded public key (flatpak-bundle.sh, via the
  scaffold's new step 4), so `flatpak install` verifies it, plus a detached .asc
- Flatpak OCI image: a containers/image signature for ghcr.io/<repo>@<digest>, which Flatpak
  checks from its signature lookaside; the flatpak job records the pushed manifest for it
- SHA256SUMS.txt.asc over every release asset, and release-signing-key.asc

The draft-release action signs before computing checksums (embedded signatures change the rpm
and deb files) and verifies every signature against the exported public key. The new
import-signing-key action is shared by the flatpak and release jobs and refuses a key that
needs a passphrase. Without the secret, releases are published unsigned with a warning.
2026-11-02 20:55:58 -05:00
dependabot[bot] 23552e0010 ci(deps): bump taiki-e/install-action
Bumps the actions group with 1 update: [taiki-e/install-action](https://github.com/taiki-e/install-action).


Updates `taiki-e/install-action` from 2.88.0 to 2.88.1
- [Release notes](https://github.com/taiki-e/install-action/releases)
- [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/taiki-e/install-action/compare/86f7a0ffb25f40114606501a311ebcfaf882ea32...68a389c788b2cd04016ce8c80ee23b80d2ab3d68)

---
updated-dependencies:
- dependency-name: taiki-e/install-action
  dependency-version: 2.88.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-11-02 11:16:45 +00:00
g1obalworlds 0a8bd343f6 Merge remote-tracking branch 'upstream/main' into ci/run-tests-for-every-tested-file
# Conflicts:
#	.github/workflows/test-freebsd.yml
2026-11-01 09:52:33 -08:00
Kristian Myram 65bc9298e4 feat(release): provide the shared contributor snapshot generator 2026-11-01 13:59:31 +01:00
Dylan M. Taylor 44a7db40b1 Merge pull request #106 from dylanmtaylor/docs/no-caller-jobs
docs: app workflows only call these shared workflows; app-specific checks move here
2026-11-01 01:06:51 -04:00
Dylan M. Taylor 75fbd9b7b5 Merge pull request #96 from g1obalworlds/fix/supply-chain-gh-repo
supply-chain: name the repository for the SBOM upload
2026-11-01 01:06:07 -04:00
Dylan M. Taylor 7ee7f15d22 Merge branch 'main' into fix/flatpak-eu-strip 2026-11-01 01:04:49 -04:00
Dylan M. Taylor 817ac1cb88 Merge pull request #99 from g1obalworlds/sonar-shard-exclude-tests
sonarcloud: leave test code out of sharded coverage, as cargo llvm-cov does
2026-11-01 01:03:24 -04:00
Dylan M. Taylor 925395fde6 Merge pull request #107 from storytold/dependabot/github_actions/actions-a6a2a90062
ci(deps): bump the actions group across 1 directory with 2 updates
2026-11-01 01:01:19 -04:00
Dylan M. Taylor 2ce6aa59c7 Merge pull request #110 from nanox333/codex/release-contributor-refresh
Release: refresh contributor credits automatically before builds
2026-11-01 01:00:55 -04:00
Dylan M. Taylor 841376d7a9 Merge pull request #119 from storytold/ci/gate-optional-packages
feat(gate): packages is optional; an empty list installs none
2026-11-01 00:59:32 -04:00
dependabot[bot] 7d24ca64b1 ci(deps): bump the actions group across 1 directory with 2 updates
Bumps the actions group with 2 updates in the / directory: [taiki-e/install-action](https://github.com/taiki-e/install-action) and [SonarSource/sonarqube-scan-action](https://github.com/sonarsource/sonarqube-scan-action).


Updates `taiki-e/install-action` from 2.87.33 to 2.88.0
- [Release notes](https://github.com/taiki-e/install-action/releases)
- [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/taiki-e/install-action/compare/645d1ab48b3cb8591684a8b730b2ccf4cb3f9568...86f7a0ffb25f40114606501a311ebcfaf882ea32)

Updates `SonarSource/sonarqube-scan-action` from 8.3.0 to 8.4.0
- [Release notes](https://github.com/sonarsource/sonarqube-scan-action/releases)
- [Commits](https://github.com/sonarsource/sonarqube-scan-action/compare/d209202bc7d53ff1cc128f7f907dac145c9d6ae9...4d1dc0c91ee400dcf8a6dddf2f705ac36542e304)

---
updated-dependencies:
- dependency-name: SonarSource/sonarqube-scan-action
  dependency-version: 8.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
- dependency-name: taiki-e/install-action
  dependency-version: 2.87.32
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-11-01 04:35:59 +00:00
52dc54c75e ci: pin install-action v2.87.33, the first that knows cargo-nextest 0.9.150 (#122)
v2.87.29 knows nextest only up to 0.9.148, so every gate and coverage run that installs the
pinned cargo-nextest@0.9.150 fell back to cargo-binstall@latest: an unpinned download, then a
binstall of nextest. v2.87.33 is the oldest release whose manifest has 0.9.150; the releases
since v2.87.29 change only tool manifests.

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 05:32:27 +01:00
Dylan M. Taylor c926ea426a fix: retry macOS release verification (#121) 2026-10-31 23:58:50 -04:00
Dylan M. Taylor 37960c37b5 fix: pass Linux tarball to Flatpak OCI publishing (#120) 2026-10-31 23:50:07 -04:00
FredAppsandClaude Opus 5.5 c1f5c18c01 feat(gate): packages is optional; an empty list installs none
Calls with nothing to install from apt (a Windows-only check, a wasm build) had to pass a package
list the gate would ignore or install for nothing. packages now defaults to empty, and the apt step
runs only on Linux legs that name packages. The README describes such second gate calls, with
their own command and cache-version, instead of keeping web builds in the app's own workflow:
the apps' CI rules now allow only calls to shared workflows (#118).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 04:26:35 +01:00
84ad881711 ci(windows-arm64): only main saves the packaging cache (#116)
Pull requests that touch Windows packaging saved their own windows-arm64-package cache (about
0.7 GB), visible only to that pull request. Every app repository is at the 10 GB cache limit,
so each one evicted a cache main's gate restores. The nightly run on main still saves it.

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 01:39:08 +01:00
Dylan M. Taylor 5cd19d05cb ci(flatpak): publish Flatpak OCI layout to GHCR alongside Flatpak builds (#113) 2026-10-31 15:33:04 -04:00
Brandon ThomasandClaude Opus 5.5 5d6a81953e fix(flatpak): install elfutils so flatpak-builder can eu-strip modules
flatpak-builder only Recommends elfutils, which --no-install-recommends skips. Apps whose
manifests now build cups-client from source (gridcraft, designcraft, wordcraft, pdfcraft) fail
in the Flatpak job with: Failed to execute child process "eu-strip".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 23:14:08 -04:00
Kristian Myram 215a7f48c1 fix(release): exclude contributor snapshots from release assets 2026-10-30 18:00:34 +01:00
Kristian Myram 3cb27117d0 Release: support automatic contributor snapshot refresh 2026-10-30 14:36:32 +00:00
FredApps 2b3fb9dc05 ci: preserve dependency cache reuse across root manifest updates (#108)
* ci: preserve dependency cache reuse across root manifest updates

* docs: align gate cache overview with profile keys and dispatch opt-in
2026-10-30 07:47:08 -04:00
Dylan M. Taylor 2959c0cdc8 docs: app workflows only call these shared workflows; app-specific checks move here
App repos' .github/workflows/ should only call craft-common-actions at @main, so CI
is the same across the Craft apps. gate.yml and the README said app-only jobs
(fuzzing, corpora, web builds, Windows installer probes) stay in the caller; they
now belong here as shared workflows or inputs, and move without being dropped.
2026-10-29 20:25:40 -04:00
Dylan M. Taylor fa5ef18780 Build FreeBSD aarch64 release archives by default (#104)
* ci(release): build FreeBSD aarch64 archives by default

app packaging/freebsd/package.sh scripts now honor CARGO_BUILD_TARGET, so
aarch64 is no longer opt-in: freebsd-architectures defaults to
'["x86_64","aarch64"]'. Callers can still narrow it to x86_64 only.

* docs(readme): FreeBSD aarch64 is in the default freebsd-architectures
2026-10-28 15:49:07 -04:00
aiongg 41e0b4e097 fix(freebsd): install cmake-core, which the quarterly package set still has (#103)
The aarch64 job uses FreeBSD's quarterly packages, which since 2026-10-28 have no `cmake` meta-package, only `cmake-core`. `pkg install cmake` failed and stopped every app's release build. `cmake-core` is in both the quarterly and latest sets.
2026-10-28 14:10:16 -04:00
Jeremy 8bb4e5ab95 fix(ci): separate ARM64 install paths and scope (#100)
* fix(ci): separate ARM64 install paths and installation scope

* test(ci): exercise ARM64 installer contract fixtures on Windows
2026-10-27 15:45:39 -04:00
g1obalworlds 160d46a16b ci: run the unit tests when any workflow or action they cover changes
test-freebsd.yml is the only workflow that runs tests/, but its path filter
still lists the FreeBSD-era files. A change to sonarcloud.yml,
supply-chain.yml, nix.yml, ast-grep.yml, or to actions such as arch-package,
resolve-version, ast-grep or checkout-craft-fonts ran none of their tests:
#86 (sonarcloud.yml and the README) and #90 (sonarcloud.yml) merged without
test_sonarcloud.py running. Match every workflow, action and test file, and
test that the filter does, with GitHub's glob rules.
2026-10-26 17:22:20 -07:00
g1obalworlds 0e8822f295 sonarcloud: leave test code out of sharded coverage, as cargo llvm-cov does
cargo llvm-cov adds its own exclusions to --ignore-filename-regex: tests/,
examples/ and benches/ directories and tests.rs / *_tests.rs files. The
sharded merge (the default since #87) calls llvm-cov export directly with
only (vendor|xtask)/, so integration tests and src/**/tests.rs reached
lcov.info as almost fully covered source, and coverage moved when a caller
switched between shards: 1 and the default. Put those exclusions in the
shared regex; the unsharded run already applies them.
2026-10-26 17:16:25 -07:00
g1obalworlds 03a637cbc0 supply-chain: name the repository for the SBOM upload
The attest job has no checkout, so `gh release upload` had no git remote to
find the repository from and failed with "not a git repository" after the
attestations were already published. Pass GH_REPO, as draft-release does.
2026-10-26 17:00:22 -07:00
skylar d07589f3fe ci: pin nextest to 0.9.150
Use the fixed release for GHSA-vc25-qg58-w57c.
2026-10-26 14:13:00 -06:00
skylar taylor-barrick be6bbf3ca5 Provision fonts and optional Python coverage for Sonar (#88)
* Provision coverage fonts for archive builds and test runners

* Keep coverage fonts optional unless a pin is requested

* Pin nested actions used by coverage jobs

* Export the font path only after a requested checkout

* Measure optional Python tooling coverage in Sonar

* ci: restore craft-common-actions tracking main

* ci: share Python coverage configuration with XML reporting
2026-10-25 23:37:12 -04:00
Dylan M. Taylor 452c0b419f sonarcloud: exclude i18n tables from duplication checks (#91) 2026-10-25 21:20:17 -04:00
Dylan M. Taylor 07683e249a sonarcloud: unpack the coverage archive outside the workspace (#90) 2026-10-25 21:17:09 -04:00
Dylan M. Taylor e3814b3ec2 sonarcloud: fail a shard that cannot run its tests instead of scanning empty coverage (#89) 2026-10-25 19:49:55 -04:00
Dylan M. Taylor 395270d2c0 sonarcloud: optionally shard Rust coverage across parallel nextest partitions (#87)
* sonarcloud: optionally shard Rust coverage across parallel nextest partitions

* sonarcloud: default coverage to four shards

* sonarcloud: build the instrumented archive once and shard tests from it

* sonarcloud: skip sharded scan steps when the plan job produces no shards

* sonarcloud: validate shard count, pin the archive's toolchain, merge only test binaries
2026-10-25 18:54:59 -04:00
Dylan M. Taylor 6182ccebfd Raise the default SonarCloud job timeout to 90 minutes (#86) 2026-10-25 17:05:09 -04:00
skylartaylor d74cca0665 Allow callers to budget longer Sonar coverage jobs 2026-10-25 21:45:03 +01:00
Dylan M. Taylor 58e2894843 security(workflows): strengthen SonarCloud project-key and FreeBSD architecture input validation (F-005, F-006, F-007, F-009, F-010)
- Restrict SonarCloud project-key grammar to start with an alphanumeric/underscore, reject leading hyphens/flags, and enforce 400 character length limit (F-006)
- Verify Nix extra-args argument parsing without eval (F-005)
- Verify Windows ARM64 PowerShell environment variable passing and path component sanitization (F-007)
- Add unit test verifying FreeBSD workflow architecture pre-validation rejects invalid architectures and injection payloads prior to VM execution (F-009)
- Verify FreeBSD custom-test-command environment data passing (F-010)
2026-10-24 22:44:09 -04:00
IvanandClaude Opus 5.5 13491f8120 ast-grep: a reusable structural-lint workflow driven by the app's sgconfig.yml (#80)
* ast-grep: a reusable structural-lint workflow driven by the app's sgconfig.yml

A reusable workflow and composite action that install a pinned
ast-grep (checked against a SHA256 kept in the action, since its
releases publish none), run the caller's rule tests when its
sgconfig.yml has testConfigs, then scan with that config. CI and a
local `ast-grep scan` read the same rules. Findings become PR
annotations; a failing scan also lists every finding as file:line,
since GitHub shows only the first few annotations of a step.

No rules ship here. test-ast-grep.yml checks the action against a
fixture: clean code passes, a finding fails, a path outside the
repository is refused.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* ast-grep: run the action from the workflow's own commit; always run rule tests

ast-grep.yml loads the action with `$/actions/ast-grep`, GitHub's
self-repository syntax, so a caller that pins the workflow to a commit,
or calls a fork's, runs the action from the same commit rather than
whatever is on main.

The rule tests no longer depend on grepping for `testConfigs:`, which
missed valid YAML such as `testConfigs :`. ast-grep test runs every
time; with no testConfigs it has no tests to run.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 19:29:21 -04:00
Martin BallandClaude Opus 5.5 9e42334399 fix(release): drop the i18n gate; missing translations never block (storytold/craft-i18n#20) (#79)
Remove i18n-gate.yml, the skip-i18n-gate input and the i18n-gate jobs in
release.yml and freebsd.yml. Keep checkout-craft-i18n and the
CRAFT_I18N_DIR / CRAFT_I18N_REQUIRED=1 env, which fail only on a
missing or invalid craft-i18n checkout.

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-23 17:06:45 -04:00
Dylan M. Taylor 93c11f0cbf release: run the storytold git-sources gate once, in the shared workflow (#78)
Moves the per-app 'Git dependencies come from storytold' job into
craft-common-actions' release.yml, gated after it via the version job, so
every craftapp gets the check at @main instead of a copy per repo.
2026-10-23 14:34:51 -04:00
Dylan M. Taylor 52677fa55b sonarcloud: free runner disk and drop debuginfo so the llvm-cov build fits (#76) 2026-10-23 13:53:45 -04:00
dependabot[bot] 1c51ea7025 ci(deps): bump the actions group across 1 directory with 2 updates (#75)
Bumps the actions group with 2 updates in the / directory: [taiki-e/install-action](https://github.com/taiki-e/install-action) and [Swatinem/rust-cache](https://github.com/swatinem/rust-cache).


Updates `taiki-e/install-action` from 2.75.0 to 2.87.29
- [Release notes](https://github.com/taiki-e/install-action/releases)
- [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/taiki-e/install-action/compare/v2.75.0...8cca0918f8471c33515202b73f56ab27f2bed283)

Updates `Swatinem/rust-cache` from 2.9.2 to 2.9.3
- [Release notes](https://github.com/swatinem/rust-cache/releases)
- [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md)
- [Commits](https://github.com/swatinem/rust-cache/compare/v2.9.2...d1527c8f67ef9af357290475d4af4b0fab8f12e0)

---
updated-dependencies:
- dependency-name: Swatinem/rust-cache
  dependency-version: 2.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
- dependency-name: taiki-e/install-action
  dependency-version: 2.87.29
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-10-23 12:29:26 -04:00
Dylan M. Taylor f63d4a783a security(freebsd): keep custom test command and architecture out of guest shell source (#73) 2026-10-23 12:29:17 -04:00