mirror of
https://github.com/storytold/artcraft.git
synced 2026-11-05 09:48:44 +00:00
Tanish Manku
c6c0b193eb
Closes the last "subsystem holds an Editor ref" holdout. SceneUtils now takes a SceneUtilsDeps surface (Phase 2 idiom — same shape as SaveManagerDeps, CameraControllerDeps, SelectionBridgeDeps, GizmoControllerDeps) instead of the full Editor. Deps surface — 9 single-purpose getters/callbacks for the cross- subsystem reaches the methods need: - Gizmo lifecycle (getGizmoControl/detachGizmo/removeGizmoFromScene) used by removeTransformControls - Outline pass (getOutlinePass) used by removeTransformControls - Selection (publishSelect/clearSelected) used by deleteObject and removeTransformControls - Camera name (getCameraName) used by deleteObject's ::CAM:: guard - Selected object lookup (getSelectedObject) used by getSelectedSum - Three scene root (getThreeScene) — provided for future use; the current deleteObject still goes through this.scene.scene since Scene is an injected primitive, not a subsystem Editor wires deps inline at SceneUtils construction. Constructor signature flips: was (editor, scene); now (scene, deps). Re P2 holdouts: ViewportController already used Deps (ViewportEngineRefs); roadmap memory was stale. PostProcessingPipeline and GizmoController.configure only take primitives (renderer/scene/ camera/dom), no subsystem coupling — converting them to options objects would be pure style and was deferred.
Frontend
This is an nx monorepo that can contain multiple apps and shared libraries.
All commands to run these projects are performed from this directory.
Install dependencies
npm install
Editor2d
Run dev server:
nx dev editor2d
artcraft
Run dev server:
nx dev artcraft
call when starting on main or a new branch:
./clean_modules
The names for @frontend and @storyteller come from the package.json file in the libs folder.
import { Login } from "@frontend/login";
import { api } from "@storyteller/api";
For shared UI components, import from @storyteller/ui-[componentname].
import { Button } from "@storyteller/ui-button";
import { Modal } from "@storyteller/ui-modal";
building:
npx nx build artcraft
npx nx build editor2d
dev:
npx nx dev artcraft
npx nx dev editor2d
# component build
1.
npx nx g @nx/react:library libs/components/toaster --import-path=@storyteller/ui-toaster --bundler=vite
npm install
2.import it first in code
3.nx sync
4.nx build
or
# frontend build
in frontend folder
% nx build -project type
% nx build artcraft
% nx dev artcraft