mirror of
https://github.com/storytold/artcraft.git
synced 2026-11-07 10:31:46 +00:00
Tanish Manku
a9fa8d710a
useFeaturedObjects' auto-fetch effect synchronously flipped firstFetch.current to IN_PROGRESS before calling fetchFeaturedObjects. On AssetModal's first mount the EngineContext editor is null, so the fetch bailed at `if (!editor) return`. When the editor later became available the effect re-fired (editor is in fetchFeaturedObjects' useCallback deps), but the IN_PROGRESS guard blocked it — the network request never fired for any featured category. CHARACTER/OBJECT tabs appeared populated only because they're merged with local demo arrays inside AssetModal's assetTabs useMemo; Sets and Creatures have no demo fallback so the bug was visible there. Move the editor check into the auto-fetch effect itself and add editor to its deps, so IN_PROGRESS isn't burned on the no-op call. Regression from PR #1492.
Frontend
This is an nx monorepo that can contain multiple apps and shared libraries.
All commands to run these projects are performed from this directory.
Install dependencies
npm install
Editor2d
Run dev server:
nx dev editor2d
artcraft
Run dev server:
nx dev artcraft
call when starting on main or a new branch:
./clean_modules
The names for @frontend and @storyteller come from the package.json file in the libs folder.
import { Login } from "@frontend/login";
import { api } from "@storyteller/api";
For shared UI components, import from @storyteller/ui-[componentname].
import { Button } from "@storyteller/ui-button";
import { Modal } from "@storyteller/ui-modal";
building:
npx nx build artcraft
npx nx build editor2d
dev:
npx nx dev artcraft
npx nx dev editor2d
# component build
1.
npx nx g @nx/react:library libs/components/toaster --import-path=@storyteller/ui-toaster --bundler=vite
npm install
2.import it first in code
3.nx sync
4.nx build
or
# frontend build
in frontend folder
% nx build -project type
% nx build artcraft
% nx dev artcraft