Tanish Manku 2a4f849940 Upload modals: stop remounting children on every parent re-render ...

`UploaderModalContent` was defined inline in each upload modal's
function body and rendered as `<UploaderModalContent />`. Each parent
re-render created a fresh component identity, which React treats as
a new component type — unmounting the old subtree and mounting a new
one. PageScene's many zustand subscriptions fire often enough that
this remount sometimes happens between mousedown and mouseup of a
click on the file uploader's drag-drop zone.

Result: original `<u>` ("Upload a file" link) is destroyed mid-click,
mouseup lands on the modal wrapper instead of `<u>`, WebView2 refuses
to synthesize `click`, and the library's native click listener that
opens the OS file picker never fires. Other pages have lighter
parent re-render frequency, so the remount usually doesn't land
inside a click window.

Render `UploaderModalContent` as a function call (`{UploaderModalContent()}`)
instead of a component instance. The function reference still
changes per render but React just sees the returned JSX inline —
no component identity, no remount.

Same fix in all five upload modals so the bug doesn't recur on any
of them.

Also strips the temporary [click-trace] debug logger from
PageEditor.tsx (which identified the cause via mid-click DOM
mutations).

2026-05-01 21:55:23 -07:00

..

artcraft

Upload modals: stop remounting children on every parent re-render

2026-05-01 21:55:23 -07:00

artcraft-website

fix: guard handleGenerate with useRef to close double-submit race

2026-04-28 22:57:27 +07:00

genhub

build fix 3

2026-03-12 21:35:29 +07:00