mirror of
https://github.com/storytold/artcraft.git
synced 2026-11-16 06:42:14 +00:00
Mutable action tags are a supply-chain risk: a moved tag runs different code without a diff. Every workflow action is now pinned through .github/workflows/actions.lock, and CI verifies the lockfile so an out-of-sync or tampered one fails instead of running. arch-package was pinned to 9d67905, a commit no longer on any branch or tag of craft-common-actions, so it is back on main like the other craft actions here. S7637 wants an inline SHA per action and does not read actions.lock, so the rule is scoped off for workflow files until Sonar reads lockfiles.
40 lines
2.8 KiB
Properties
40 lines
2.8 KiB
Properties
sonar.projectKey=storytold_artcraft
|
|
sonar.organization=storytold
|
|
|
|
# CI only publishes the Rust lcov report, so TypeScript and JavaScript never
|
|
# appear covered. Same idea as anicraft excluding JS/PowerShell/Python, and
|
|
# as filmcraft and lightcraft excluding tools/docs/examples.
|
|
sonar.coverage.exclusions=**/*.ts,**/*.tsx,**/*.js,**/*.jsx
|
|
|
|
|
|
# Not analysed: code that isn't ArtCraft's or isn't run by the app or CI.
|
|
# - crates/vendor/: third-party crates kept in the tree.
|
|
# - The Python beside the Grok and Sora clients: the upstream reference implementations the Rust ports
|
|
# cite ("Based on Grok-Api/core/xctid.py"); nothing runs them.
|
|
# - frontend/scripts/unix-dev.mjs and frontend/tools/performance/: developer tools run by hand
|
|
# (script/artcraft/unix_dev.sh, `npm run perf:desktop`); they start git, cargo and a browser from
|
|
# the developer's own PATH and write where the developer says.
|
|
sonar.exclusions=crates/vendor/**,crates/api_clients/grok_consumer_client/src/credentials/_metadata/**,crates/api_clients/openai_sora_client/src/requests/auth_sentinel_2/metadata/python_impl/**,frontend/scripts/unix-dev.mjs,frontend/tools/performance/**
|
|
|
|
# S4347 (predictable seed): DeterministicRng is the fixed-seed generator for tests and dev seed
|
|
# tools; being reproducible is its purpose.
|
|
# S2187 (file without tests): the API tests build their cases with the shared helpers in
|
|
# test/app/Classes/ApiManager/utils/, which call `it` themselves.
|
|
# S2819 (message origin): a dedicated worker's `message` events come only from the page that
|
|
# started it; they carry no origin to check.
|
|
sonar.issue.ignore.multicriteria=deterministic_rng,api_test_helpers,worker_messages,gha-lockfile
|
|
sonar.issue.ignore.multicriteria.deterministic_rng.ruleKey=rust:S4347
|
|
sonar.issue.ignore.multicriteria.deterministic_rng.resourceKey=crates/schema/public/tokens/src/deterministic_rng.rs
|
|
sonar.issue.ignore.multicriteria.api_test_helpers.ruleKey=typescript:S2187
|
|
sonar.issue.ignore.multicriteria.api_test_helpers.resourceKey=frontend/apps/artcraft/test/app/Classes/ApiManager/**
|
|
sonar.issue.ignore.multicriteria.worker_messages.ruleKey=typescript:S2819
|
|
sonar.issue.ignore.multicriteria.worker_messages.resourceKey=**/*.worker.ts
|
|
|
|
# githubactions:S7637 asks for every action to be pinned to a commit SHA. A workflow covered by
|
|
# .github/workflows/actions.lock runs the commit the lockfile records, so its tag refs are pinned
|
|
# and the lockfile covers the actions those actions use too. Sonar does not read lockfiles yet, so
|
|
# the rule flags the tag refs anyway:
|
|
# https://community.sonarsource.com/t/githubactions-s7637-false-positives-for-actions-pinned-through-native-actions-lock/190814
|
|
sonar.issue.ignore.multicriteria.gha-lockfile.ruleKey=githubactions:S7637
|
|
sonar.issue.ignore.multicriteria.gha-lockfile.resourceKey=.github/workflows/**
|