From eb4f06179ebde4cf6a38925c2edcaaa41e90397d Mon Sep 17 00:00:00 2001
From: Madhukar Mishra <madhukar93@gmail.com>
Date: Mon, 8 Jan 2024 19:22:37 +0530
Subject: [PATCH] fixup

---
 .../service/job/inference_job/src/job/job_loop/main_loop.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/crates/service/job/inference_job/src/job/job_loop/main_loop.rs b/crates/service/job/inference_job/src/job/job_loop/main_loop.rs
index f3d9830923..c41961f761 100644
--- a/crates/service/job/inference_job/src/job/job_loop/main_loop.rs
+++ b/crates/service/job/inference_job/src/job/job_loop/main_loop.rs
@@ -124,7 +124,7 @@ async fn process_job_batch(job_dependencies: &JobDependencies, jobs: Vec<Availab
   let job_count = jobs.len();
   let meter = otel::meter(OTEL_METER_NAME);
   // TODO: total_duration as histogram for min/max/avg/percentiles
-  let job_duration = meter.i64_observable_gauge("job_duration").with_unit(metrics::Unit::new("ms")).init();
+  let job_duration_metric = meter.i64_observable_gauge("job_duration").with_unit(metrics::Unit::new("ms")).init();
 
   for (i, job) in jobs.into_iter().enumerate() {
     let start_time = Instant::now();
@@ -155,10 +155,10 @@ async fn process_job_batch(job_dependencies: &JobDependencies, jobs: Vec<Availab
       }
     }
     let job_duration = Instant::now().duration_since(start_time);;
-    job_duration.observe(job_duration.as_millis(),
+    job_duration_metric.observe(job_duration.as_millis(),
       &[
         // TODO: need job_ prefix?
-        OtelAttribute::new("job_id", job.id),
+        OtelAttribute::new("job_id", format!("{}", job.id)),
         OtelAttribute::new("job_inference_category", job.inference_category.to_str()),
         OtelAttribute::new("job_inference_token", job.inference_job_token.as_str()),
       ]