From cd0c35de4ae2e7946c71fd71660971fa1ccc5e73 Mon Sep 17 00:00:00 2001 From: Brandon Thomas Date: Fri, 5 Jan 2024 23:54:13 -0500 Subject: [PATCH] fix increment logic --- .../user_bookmarks/create_user_bookmark_handler.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/crates/service/web/storyteller_web/src/http_server/endpoints/user_bookmarks/create_user_bookmark_handler.rs b/crates/service/web/storyteller_web/src/http_server/endpoints/user_bookmarks/create_user_bookmark_handler.rs index 4b5853b1b3..1ecb7b83b3 100644 --- a/crates/service/web/storyteller_web/src/http_server/endpoints/user_bookmarks/create_user_bookmark_handler.rs +++ b/crates/service/web/storyteller_web/src/http_server/endpoints/user_bookmarks/create_user_bookmark_handler.rs @@ -178,7 +178,13 @@ pub async fn create_user_bookmark_handler( } }; - if maybe_existing_user_bookmark.is_none() { + // Increment only if we're creating or undeleting a bookmark + let increment_bookmark_count = + maybe_existing_user_bookmark.is_none() || + maybe_existing_user_bookmark.map(|bookmark| bookmark.maybe_deleted_at.is_some()) + .unwrap_or(false); + + if increment_bookmark_count { // NB: Not all bookmarkable things have stats (eg. deprecated record types don't have stats). let maybe_stats_entity_token = StatsEntityToken::from_bookmark_entity_type_and_token(request.entity_type, &request.entity_token);