From bd653c70d88bcac60c16ba9d8a3dead6e483a0c4 Mon Sep 17 00:00:00 2001 From: Kasisnu <5044120+kasisnu@users.noreply.github.com> Date: Tue, 13 Feb 2024 21:55:42 +0530 Subject: [PATCH] return errors from conversion endpoints when media file isnt sent --- .../endpoints/conversion/enqueue_bvh_to_workflow_handler.rs | 4 ++++ .../endpoints/conversion/enqueue_fbx_to_gltf_handler.rs | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/crates/service/web/storyteller_web/src/http_server/endpoints/conversion/enqueue_bvh_to_workflow_handler.rs b/crates/service/web/storyteller_web/src/http_server/endpoints/conversion/enqueue_bvh_to_workflow_handler.rs index 62bbb90b6b..43d440e6c5 100644 --- a/crates/service/web/storyteller_web/src/http_server/endpoints/conversion/enqueue_bvh_to_workflow_handler.rs +++ b/crates/service/web/storyteller_web/src/http_server/endpoints/conversion/enqueue_bvh_to_workflow_handler.rs @@ -184,6 +184,10 @@ pub async fn enqueue_bvh_to_workflow_handler( let maybe_avt_token = server_state.avt_cookie_manager .get_avt_token_from_request(&http_request); + if request.media_file_token.as_str().is_empty() { + return Err(EnqueueBvhToWorkflowRequestError::BadInput("media_file_token is empty".to_string())); + } + let query_result = insert_generic_inference_job(InsertGenericInferenceArgs { uuid_idempotency_token: &request.uuid_idempotency_token, inference_category: InferenceCategory::ConvertBvhToWorkflow, diff --git a/crates/service/web/storyteller_web/src/http_server/endpoints/conversion/enqueue_fbx_to_gltf_handler.rs b/crates/service/web/storyteller_web/src/http_server/endpoints/conversion/enqueue_fbx_to_gltf_handler.rs index c8e7bb8af4..a2f0fbe632 100644 --- a/crates/service/web/storyteller_web/src/http_server/endpoints/conversion/enqueue_fbx_to_gltf_handler.rs +++ b/crates/service/web/storyteller_web/src/http_server/endpoints/conversion/enqueue_fbx_to_gltf_handler.rs @@ -184,6 +184,10 @@ pub async fn enqueue_fbx_to_gltf_handler( let maybe_avt_token = server_state.avt_cookie_manager .get_avt_token_from_request(&http_request); + if request.media_file_token.as_str().is_empty() { + return Err(EnqueueFbxToGltfRequestError::BadInput("media_file_token is empty".to_string())); + } + let query_result = insert_generic_inference_job(InsertGenericInferenceArgs { uuid_idempotency_token: &request.uuid_idempotency_token, job_type: InferenceJobType::ConvertFbxToGltf,