From b68d24040f4fb1b20aa8367a526bd6e764e4dff7 Mon Sep 17 00:00:00 2001 From: Brandon Thomas Date: Mon, 6 Apr 2026 20:36:06 -0400 Subject: [PATCH] rename variant --- .../common_responses/advanced_common_web_error.rs | 2 +- .../src/http_server/common_responses/common_web_error.rs | 2 +- .../src/http_server/session/session_checker_error.rs | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/crates/service/web/storyteller_web/src/http_server/common_responses/advanced_common_web_error.rs b/crates/service/web/storyteller_web/src/http_server/common_responses/advanced_common_web_error.rs index 58da4bc0a3..70826e347e 100644 --- a/crates/service/web/storyteller_web/src/http_server/common_responses/advanced_common_web_error.rs +++ b/crates/service/web/storyteller_web/src/http_server/common_responses/advanced_common_web_error.rs @@ -206,7 +206,7 @@ impl From Self::NotAuthorized, + SessionCheckerError::SessionPayload(_) => Self::NotAuthorized, // Underlying DB / cache errors → 500 with paging SessionCheckerError::Sqlx(err) => Self::from_error(err), SessionCheckerError::OtherError(err) => Self::from_anyhow_error(err), diff --git a/crates/service/web/storyteller_web/src/http_server/common_responses/common_web_error.rs b/crates/service/web/storyteller_web/src/http_server/common_responses/common_web_error.rs index e4c774a23e..3d248210c2 100644 --- a/crates/service/web/storyteller_web/src/http_server/common_responses/common_web_error.rs +++ b/crates/service/web/storyteller_web/src/http_server/common_responses/common_web_error.rs @@ -114,7 +114,7 @@ impl From Self::NotAuthorized, + SessionCheckerError::SessionPayload(_) => Self::NotAuthorized, // Underlying DB / cache errors → 500 SessionCheckerError::Sqlx(err) => { error!("SessionChecker sqlx error: {:?}", err); diff --git a/crates/service/web/storyteller_web/src/http_server/session/session_checker_error.rs b/crates/service/web/storyteller_web/src/http_server/session/session_checker_error.rs index 67da8b9c7d..3e52cafb27 100644 --- a/crates/service/web/storyteller_web/src/http_server/session/session_checker_error.rs +++ b/crates/service/web/storyteller_web/src/http_server/session/session_checker_error.rs @@ -9,7 +9,7 @@ pub enum SessionCheckerError { /// Rate of failures can point to the cause: /// - One-off errors: probably session forgeries /// - Lots of errors: maybe the wrong hmac secret - Session(HttpUserSessionPayloadError), + SessionPayload(HttpUserSessionPayloadError), /// Error looking up the session from the database. Sqlx(sqlx::Error), @@ -21,7 +21,7 @@ pub enum SessionCheckerError { impl Display for SessionCheckerError { fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { match self { - Self::Session(e) => write!(f, "session error: {}", e), + Self::SessionPayload(e) => write!(f, "session payload error: {}", e), Self::Sqlx(e) => write!(f, "sqlx error: {}", e), Self::OtherError(e) => write!(f, "other error: {}", e), } @@ -32,7 +32,7 @@ impl Error for SessionCheckerError {} impl From for SessionCheckerError { fn from(err: HttpUserSessionPayloadError) -> Self { - Self::Session(err) + Self::SessionPayload(err) } }