From b4fe44760a6b2dcf911dcdabdf2b280b601270af Mon Sep 17 00:00:00 2001
From: Brandon Thomas <echelon@gmail.com>
Date: Sat, 26 Feb 2022 03:33:19 -0500
Subject: [PATCH] notes, dynamic create title

---
 .../shared/TwitchEventCategory.ts             |  6 ++
 packages/storyteller/src/App.tsx              |  2 +-
 .../tts_configs/TtsConfigsCreateRulePage.tsx  | 59 +++++++------------
 .../tts_configs/TtsConfigsEditRulePage.tsx    |  2 +-
 .../EventMatchPredicateBuilderComponent.tsx   |  3 +
 .../EventResponseComponent.tsx                |  3 +
 6 files changed, 36 insertions(+), 39 deletions(-)

diff --git a/packages/components/src/api/storyteller/twitch_event_rules/shared/TwitchEventCategory.ts b/packages/components/src/api/storyteller/twitch_event_rules/shared/TwitchEventCategory.ts
index 36ef9efdb4..825413bdca 100644
--- a/packages/components/src/api/storyteller/twitch_event_rules/shared/TwitchEventCategory.ts
+++ b/packages/components/src/api/storyteller/twitch_event_rules/shared/TwitchEventCategory.ts
@@ -4,3 +4,9 @@ export enum TwitchEventCategory {
   ChannelPoints = "channel_points",
   ChatCommand = "chat_command",
 };
+
+export const TWITCH_EVENT_CATEGORY_BY_STRING = new Map<string, TwitchEventCategory>([
+  ["bits", TwitchEventCategory.Bits],
+  ["channel_points", TwitchEventCategory.ChannelPoints],
+]);
+
diff --git a/packages/storyteller/src/App.tsx b/packages/storyteller/src/App.tsx
index 9829a734c2..1e101f1e7d 100644
--- a/packages/storyteller/src/App.tsx
+++ b/packages/storyteller/src/App.tsx
@@ -140,7 +140,7 @@ class App extends React.Component<Props, State> {
                   querySessionAction={this.querySession}
                   />
               </Route>
-              <Route path="/tts_configs/create/:eventCategory">
+              <Route path="/tts_configs/create/:event_category">
                 <TtsConfigsCreateRulePage
                   sessionWrapper={this.state.sessionWrapper}
                   allTtsModels={this.state.allTtsModels}
diff --git a/packages/storyteller/src/pages/tts_configs/TtsConfigsCreateRulePage.tsx b/packages/storyteller/src/pages/tts_configs/TtsConfigsCreateRulePage.tsx
index 3e5bb61733..fe9fee2c21 100644
--- a/packages/storyteller/src/pages/tts_configs/TtsConfigsCreateRulePage.tsx
+++ b/packages/storyteller/src/pages/tts_configs/TtsConfigsCreateRulePage.tsx
@@ -1,9 +1,9 @@
-import React, { useEffect, useState } from 'react';
+import React, { useState } from 'react';
 import { SessionWrapper } from '@storyteller/components/src/session/SessionWrapper';
 import { TtsModelListItem } from '@storyteller/components/src/api/tts/ListTtsModels';
 import { TwitchEventRule } from '@storyteller/components/src/api/storyteller/twitch_event_rules/GetTwitchEventRule';
 import { Link, useHistory, useParams } from 'react-router-dom';
-import { TwitchEventCategory } from '@storyteller/components/src/api/storyteller/twitch_event_rules/shared/TwitchEventCategory';
+import { TwitchEventCategory, TWITCH_EVENT_CATEGORY_BY_STRING } from '@storyteller/components/src/api/storyteller/twitch_event_rules/shared/TwitchEventCategory';
 import { EventResponse } from '@storyteller/components/src/api/storyteller/twitch_event_rules/shared/EventResponse';
 import { EventMatchPredicate } from '@storyteller/components/src/api/storyteller/twitch_event_rules/shared/EventMatchPredicate';
 import { CreateTwitchEventRule, CreateTwitchEventRuleRequest } from '@storyteller/components/src/api/storyteller/twitch_event_rules/CreateTwitchEventRule';
@@ -12,8 +12,6 @@ import { EventResponseComponent } from './event_response_builder/EventResponseCo
 import { TwitchEventRuleElement } from './TwitchEventRuleElement';
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import { faAngleLeft, faSave } from '@fortawesome/free-solid-svg-icons';
-import { buildEventResponse } from './event_response_builder/BuildEventResponse';
-import { EventResponseType } from './event_response_builder/EventResponseType';
 
 interface Props {
   sessionWrapper: SessionWrapper,
@@ -22,28 +20,30 @@ interface Props {
 }
 
 function TtsConfigsCreateRulePage(props: Props) {
-  const { eventCategory } = useParams() as { eventCategory : string };
+  const { event_category } = useParams() as { event_category : string };
+
+  const history = useHistory();
 
   // TODO: Use centralized configs
   const indexLink = '/tts_configs';
 
-  const history = useHistory();
-
   // ========== In-Progress Model Edits ==========
 
-  const [twitchEventCategory, setTwitchEventCategory] = useState<TwitchEventCategory>(TwitchEventCategory.Bits);
   const [ruleIsDisabled, setRuleIsDisabled] = useState(false);
 
   const [modifiedEventMatchPredicate, setModifiedEventMatchPredicate] = useState<EventMatchPredicate>({});
   const [modifiedEventResponse, setModifiedEventResponse] = useState<EventResponse>({});
 
-  const handleChangeTwitchEventCategory = (ev: React.FormEvent<HTMLSelectElement>) : boolean => {
-    const value = (ev.target as HTMLSelectElement).value;
-    const newTwitchEventCategory = value as TwitchEventCategory;
-    setTwitchEventCategory(newTwitchEventCategory);
-    return true;
+
+  let maybeTwitchEventCategory = TWITCH_EVENT_CATEGORY_BY_STRING.get(event_category);
+
+  if (maybeTwitchEventCategory === undefined) {
+    history.push(indexLink);
+    return <></>;
   }
-  
+
+  const twitchEventCategory = maybeTwitchEventCategory;
+
   const updateModifiedEventMatchPredicate = (predicate: EventMatchPredicate) => {
     // TODO
     setModifiedEventMatchPredicate(predicate);
@@ -105,10 +105,17 @@ function TtsConfigsCreateRulePage(props: Props) {
   const emptyEventMatchPredicate = {};
   const emptyEventResponse = {};
 
+  const titlesByCategory = new Map<TwitchEventCategory, string>([
+    [TwitchEventCategory.Bits, 'Create New Bits / Cheers Rule'],
+    [TwitchEventCategory.ChannelPoints, 'Create New Channel Points Rule'],
+  ]);
+
+  const pageTitle = titlesByCategory.get(twitchEventCategory);
+
   return (
     <>
       <div className="section">
-        <h1 className="title"> Create New Rule </h1>
+        <h1 className="title"> {pageTitle} </h1>
       </div>
 
       <br />
@@ -116,28 +123,6 @@ function TtsConfigsCreateRulePage(props: Props) {
 
       <form onSubmit={handleFormSubmit}>
 
-        <h2 className="title is-4">1) Pick the type of event </h2>
-
-        <div className="field">
-          <div className="control">
-            <div className="select is-medium is-fullwidth">
-              <select 
-                value={twitchEventCategory}
-                onChange={handleChangeTwitchEventCategory}>
-                <option 
-                  value={TwitchEventCategory.Bits}
-                  >Bits and Cheering</option>
-                <option 
-                  value={TwitchEventCategory.ChannelPoints}
-                  >Channel Points</option>
-              </select>
-            </div>
-          </div>
-        </div>
-
-        <br />
-        <br />
-
         <EventMatchPredicateBuilderComponent
           twitchEventCategory={twitchEventCategory}
           serverEventMatchPredicate={emptyEventMatchPredicate}
diff --git a/packages/storyteller/src/pages/tts_configs/TtsConfigsEditRulePage.tsx b/packages/storyteller/src/pages/tts_configs/TtsConfigsEditRulePage.tsx
index ffc032c1fc..57ca0dff9f 100644
--- a/packages/storyteller/src/pages/tts_configs/TtsConfigsEditRulePage.tsx
+++ b/packages/storyteller/src/pages/tts_configs/TtsConfigsEditRulePage.tsx
@@ -19,9 +19,9 @@ interface Props {
 }
 
 function TtsConfigsEditRulePage(props: Props) {
-  // TODO: Use centralized configs
   const { token } : { token : string } = useParams();
 
+  // TODO: Use centralized URL configs
   const indexLink = '/tts_configs';
 
   const history = useHistory();
diff --git a/packages/storyteller/src/pages/tts_configs/event_match_predicate_builder/EventMatchPredicateBuilderComponent.tsx b/packages/storyteller/src/pages/tts_configs/event_match_predicate_builder/EventMatchPredicateBuilderComponent.tsx
index 82e609d15a..ff14e57b9c 100644
--- a/packages/storyteller/src/pages/tts_configs/event_match_predicate_builder/EventMatchPredicateBuilderComponent.tsx
+++ b/packages/storyteller/src/pages/tts_configs/event_match_predicate_builder/EventMatchPredicateBuilderComponent.tsx
@@ -11,6 +11,9 @@ import { CheerUtil } from '../../../twitch/CheerUtil';
 import { CheerState, CheerStateIsCustom, CheerStateIsOfficial, cheerStateToPredicate, predicateToCheerState } from './CheerState';
 import { CHEER_LOOKUP_MAP } from '../../../twitch/Cheers';
 
+// NB: This was created for "Edit" view, but we've forced it to work for "Create" view by hardcoding 
+// values that don't actually come from the server.
+
 interface EventMatchPredicateBuilderComponentProps {
   // CANNOT BE CHANGED AFTER CREATION
   twitchEventCategory: TwitchEventCategory,
diff --git a/packages/storyteller/src/pages/tts_configs/event_response_builder/EventResponseComponent.tsx b/packages/storyteller/src/pages/tts_configs/event_response_builder/EventResponseComponent.tsx
index 5ede1bf6ab..88505c001d 100644
--- a/packages/storyteller/src/pages/tts_configs/event_response_builder/EventResponseComponent.tsx
+++ b/packages/storyteller/src/pages/tts_configs/event_response_builder/EventResponseComponent.tsx
@@ -6,6 +6,9 @@ import { EventResponse } from '@storyteller/components/src/api/storyteller/twitc
 import { buildEventResponse } from './BuildEventResponse';
 import { TtsRandomVoiceForm } from './TtsRandomVoiceForm';
 
+// NB: This was created for "Edit" view, but we've forced it to work for "Create" view by hardcoding 
+// values that don't actually come from the server.
+
 interface EventResponseComponentProps {
   // Original response from server.
   // (also immutable for sanity and because we may lose info on UI changes)