diff --git a/Cranky.toml b/Cranky.toml index c8443871a6..6ffc275dd4 100644 --- a/Cranky.toml +++ b/Cranky.toml @@ -32,6 +32,7 @@ deny = [ "clippy::empty_structs_with_brackets", # Lint: {} feels less aesthetic than ; "clippy::implicit_clone", # Lint: Recommendation here seems more idiomatic. "clippy::option_option", # Lint: Don't ever Option>! Enums instead. + "clippy::redundant_field_names", # Lint: Duplicate names is a burden when reading: you wonder why they're dupes. "clippy::redundant_static_lifetimes", # Lint: feels more modern to elide static lifetimes "clippy::zero_sized_map_values", # Lint: use a HashSet instead of HashMap. @@ -45,6 +46,7 @@ warn = [ allow = [ # Rust + "deprecated", # Other systems can handle deprecated code instead of the linter "missing_docs", # Not everything needs documentation. Too much documentation is bad. Literate code. # Clippy diff --git a/crates/lib/url_config/src/third_party_url_redirector.rs b/crates/lib/url_config/src/third_party_url_redirector.rs index 6f919c8b45..27a584d324 100644 --- a/crates/lib/url_config/src/third_party_url_redirector.rs +++ b/crates/lib/url_config/src/third_party_url_redirector.rs @@ -3,7 +3,6 @@ use actix_web::http::Uri; use anyhow::anyhow; use http_server_common::request::get_request_host::get_request_host; use reusable_types::server_environment::ServerEnvironment; -use std::ops::Deref; use std::str::FromStr; /// Multi-environment configuration for 3rd party redirects, eg. Stripe checkout flow and @@ -51,7 +50,6 @@ impl ThirdPartyUrlRedirector { let maybe_host = parts.get(0).map(|s| *s); let maybe_port = parts .get(1) - .map(|p| p.deref()) .map(|p| u32::from_str(p)) .transpose()?; diff --git a/execute_lints.sh b/execute_lints.sh index df0e1b5fd8..a2a8f557f2 100755 --- a/execute_lints.sh +++ b/execute_lints.sh @@ -6,10 +6,13 @@ echo 'Running lints...' # TODO: 'fakeyou_client' is broken # TODO: 'sqlite_queries' and 'aichatbot-sidecar' are broken due to sqlite +# newrelic excluded since we don't author it cargo cranky \ --workspace \ - --exclude sqlite_queries \ - --exclude fakeyou_client \ --exclude aichatbot-sidecar \ + --exclude fakeyou_client \ + --exclude sqlite_queries \ + --exclude newrelic-telemetry +echo 'Lints passed.' diff --git a/execute_tests.sh b/execute_tests.sh index d8c3e2e52a..449511c0f3 100755 --- a/execute_tests.sh +++ b/execute_tests.sh @@ -9,11 +9,11 @@ echo 'Running tests...' cargo test \ --workspace \ - --exclude sqlite_queries \ --exclude aichatbot-sidecar \ - --exclude fakeyou_client \ --exclude billing_component \ - --exclude inference-job + --exclude fakeyou_client \ + --exclude inference-job \ + --exclude sqlite_queries # Single broken tests cargo test \ @@ -21,3 +21,4 @@ cargo test \ -- \ --skip util::audiowmark::tests::test_audiowmark +echo 'Tests passed.'