From a4e8e68b8b606d10184ab6ab418fb50e04bc74bf Mon Sep 17 00:00:00 2001 From: wil Date: Wed, 29 May 2024 15:24:24 -0400 Subject: [PATCH] Fix Sidepanel setState Race Condition (#436) SidePanel has many children Panels that is trying to setState while the SidePanel holder itself is trying to set state, creating a setState race. problem is fixed by eliminating a unnecessary setState. Co-authored-by: wil --- .../PageEnigma/comps/SidePanelTabs/SidePanelTabs.tsx | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/app/pages/PageEnigma/comps/SidePanelTabs/SidePanelTabs.tsx b/app/pages/PageEnigma/comps/SidePanelTabs/SidePanelTabs.tsx index 89c2e841b4..7ddf37823b 100644 --- a/app/pages/PageEnigma/comps/SidePanelTabs/SidePanelTabs.tsx +++ b/app/pages/PageEnigma/comps/SidePanelTabs/SidePanelTabs.tsx @@ -1,20 +1,13 @@ import { useSignals } from "@preact/signals-react/runtime"; import { selectedTab, sidePanelHeight } from "~/pages/PageEnigma/signals"; -import { - TabItem, - tabList, -} from "~/pages/PageEnigma/comps/SidePanelTabs/tabList"; +import { tabList } from "~/pages/PageEnigma/comps/SidePanelTabs/tabList"; import { useMouseEventsSidePanel } from "~/pages/PageEnigma/comps/Timeline/utils/useMouseEventsSidePanel"; -import { useLayoutEffect, useState } from "react"; import { environmentVariables } from "~/signals"; export const SidePanelTabs = () => { useSignals(); const { onPointerDown } = useMouseEventsSidePanel(); - const [tabs, setTabs] = useState(); - useLayoutEffect(() => { - setTabs(tabList(environmentVariables.value)); - }, []); + const tabs = tabList(environmentVariables.value); return ( <>