From a3ee3d0c8d71f9b441cd99a941ae9cbc73a970be Mon Sep 17 00:00:00 2001
From: Brandon Thomas <echelon@gmail.com>
Date: Fri, 3 Sep 2021 04:49:25 -0400
Subject: [PATCH] even cleaner

---
 vocodes/src/v2/api/user/GetUserByUsername.ts | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/vocodes/src/v2/api/user/GetUserByUsername.ts b/vocodes/src/v2/api/user/GetUserByUsername.ts
index 1730eb7805..27542a5955 100644
--- a/vocodes/src/v2/api/user/GetUserByUsername.ts
+++ b/vocodes/src/v2/api/user/GetUserByUsername.ts
@@ -54,7 +54,6 @@ export function GetUserByUsernameIsErr(response: GetUserByUsernameResponse): res
   return !response.hasOwnProperty('user_token');
 }
 
-
 interface ProfileResponsePayload {
   success: boolean,
   error_reason?: string,
@@ -80,16 +79,15 @@ export async function GetUserByUsername(username: string) : Promise<GetUserByUse
       return response.user!;
     } 
 
-    let errorType = UserLookupError.FrontendError;
-    
     if (response?.success === false) {
       if (response.error_reason?.includes("not found")) {
-        errorType = UserLookupError.NotFound;
+        return UserLookupError.NotFound;
       } else {
-        errorType = UserLookupError.ServerError;
+        return UserLookupError.ServerError;
       }
     }
-    return errorType;
+
+    return UserLookupError.FrontendError;
   })
   .catch(e => {
     return UserLookupError.FrontendError;