From 4c66c39109ec2c340074709579f2cf1c280eeaba Mon Sep 17 00:00:00 2001 From: Tanish Manku Date: Fri, 8 May 2026 09:30:35 -0700 Subject: [PATCH] 3D editor: drop render-trace debug, clarify upload modal comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the TEMP render counters from PageEditor / Controls3D / UploadModal3D now that the inline-component-anti-pattern bug is understood and fixed. Investigation showed the apparent "4 renders per click" was a StrictMode dev artifact (one real render, doubled, hitting two UploadModal3D instances). The single re-render is benign on its own — the bug was always that registered a fresh component reference each render and remounted the dropzone mid-click. Update the call-site comment in all five upload modals to spell out the consequence (file picker breaks) so the inline call form isn't mistakenly "cleaned up" back to . --- .../reusable/UploadModal3D/UploadModal3D.tsx | 23 ++----------- .../UploadModalImage/UploadModalImage.tsx | 2 +- .../UploadImageMediaModal.tsx | 2 +- .../UploadModalMedia/UploadModalMedia.tsx | 2 +- .../UploadModalSplat/UploadModalSplat.tsx | 2 +- .../app/src/pages/PageScene/PageEditor.tsx | 6 ---- .../PageScene/comps/Controls3D/Controls3D.tsx | 32 +------------------ 7 files changed, 7 insertions(+), 62 deletions(-) diff --git a/frontend/apps/artcraft/app/src/components/reusable/UploadModal3D/UploadModal3D.tsx b/frontend/apps/artcraft/app/src/components/reusable/UploadModal3D/UploadModal3D.tsx index e0020387d7..95d12088b6 100644 --- a/frontend/apps/artcraft/app/src/components/reusable/UploadModal3D/UploadModal3D.tsx +++ b/frontend/apps/artcraft/app/src/components/reusable/UploadModal3D/UploadModal3D.tsx @@ -1,4 +1,4 @@ -import { useEffect, useMemo, useRef, useState } from "react"; +import { useEffect, useMemo, useState } from "react"; import { Checkbox } from "@storyteller/ui-checkbox"; import { LoadingDots } from "@storyteller/ui-loading"; import { Modal } from "@storyteller/ui-modal"; @@ -39,25 +39,6 @@ export function UploadModal3D(props: Props) { useState(initialUploaderState); const [isCharacter, setIsCharacter] = useState(false); - // TEMP debug: render counter — see why this re-renders mid-click. - const renderRef = useRef({ count: 0, prev: null as Record | null }); - renderRef.current.count += 1; - const traced = { isOpen, uploaderStateStatus: uploaderState.status, isCharacter }; - const diff: Record = {}; - if (renderRef.current.prev) { - for (const k of Object.keys(traced) as Array) { - if (renderRef.current.prev[k] !== traced[k]) { - diff[k] = [renderRef.current.prev[k], traced[k]]; - } - } - } - // eslint-disable-next-line no-console - console.debug( - `[render-trace] UploadModal3D #${renderRef.current.count}`, - Object.keys(diff).length ? { diff } : { same: traced }, - ); - renderRef.current.prev = traced; - const selectedCategory = isCharacter ? FilterEngineCategories.CHARACTER : FilterEngineCategories.OBJECT; @@ -184,7 +165,7 @@ export function UploadModal3D(props: Props) { className="max-w-xl" showClose={true} > - {/* Inline call — `` would be a fresh component reference each render and remount the subtree. */} + {/* Inline call — `` would be a fresh component reference each render, remounting the dropzone mid-click and breaking the file picker. */} {UploaderModalContent()} ); diff --git a/frontend/apps/artcraft/app/src/components/reusable/UploadModalImage/UploadModalImage.tsx b/frontend/apps/artcraft/app/src/components/reusable/UploadModalImage/UploadModalImage.tsx index 6a4bda62df..6df6b2f134 100644 --- a/frontend/apps/artcraft/app/src/components/reusable/UploadModalImage/UploadModalImage.tsx +++ b/frontend/apps/artcraft/app/src/components/reusable/UploadModalImage/UploadModalImage.tsx @@ -129,7 +129,7 @@ export function UploadModalImage(props: Props) { className="max-w-xl" showClose={true} > - {/* Inline call — `` would be a fresh component reference each render and remount the subtree. */} + {/* Inline call — `` would be a fresh component reference each render, remounting the dropzone mid-click and breaking the file picker. */} {UploaderModalContent()} ); diff --git a/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadImageMediaModal.tsx b/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadImageMediaModal.tsx index cfc13c6340..94ff4dfebc 100644 --- a/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadImageMediaModal.tsx +++ b/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadImageMediaModal.tsx @@ -113,7 +113,7 @@ export function UploadImageMediaModal({ return ( - {/* Inline call — `` would be a fresh component reference each render and remount the subtree. */} + {/* Inline call — `` would be a fresh component reference each render, remounting the dropzone mid-click and breaking the file picker. */} {UploaderModalContent()} ); diff --git a/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadModalMedia.tsx b/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadModalMedia.tsx index 7e154cb67c..2c3c528e56 100644 --- a/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadModalMedia.tsx +++ b/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadModalMedia.tsx @@ -100,7 +100,7 @@ export function UploadModalMedia({ return ( - {/* Inline call — `` would be a fresh component reference each render and remount the subtree. */} + {/* Inline call — `` would be a fresh component reference each render, remounting the dropzone mid-click and breaking the file picker. */} {UploaderModalContent()} ); diff --git a/frontend/apps/artcraft/app/src/components/reusable/UploadModalSplat/UploadModalSplat.tsx b/frontend/apps/artcraft/app/src/components/reusable/UploadModalSplat/UploadModalSplat.tsx index c76d4aeb0a..8179f8e592 100644 --- a/frontend/apps/artcraft/app/src/components/reusable/UploadModalSplat/UploadModalSplat.tsx +++ b/frontend/apps/artcraft/app/src/components/reusable/UploadModalSplat/UploadModalSplat.tsx @@ -137,7 +137,7 @@ export function UploadModalSplat(props: Props) { className="max-w-xl" showClose={true} > - {/* Inline call — `` would be a fresh component reference each render and remount the subtree. */} + {/* Inline call — `` would be a fresh component reference each render, remounting the dropzone mid-click and breaking the file picker. */} {UploaderModalContent()} ); diff --git a/frontend/apps/artcraft/app/src/pages/PageScene/PageEditor.tsx b/frontend/apps/artcraft/app/src/pages/PageScene/PageEditor.tsx index 0b74ca0706..0227f8e9db 100644 --- a/frontend/apps/artcraft/app/src/pages/PageScene/PageEditor.tsx +++ b/frontend/apps/artcraft/app/src/pages/PageScene/PageEditor.tsx @@ -83,12 +83,6 @@ export const PageEditor = () => { const { triggerRecheck } = useLoginModalStore(); const { status } = authentication; - // TEMP debug: render counter — see whether PageEditor re-renders mid-click. - const _peRenderCount = useRef(0); - _peRenderCount.current += 1; - // eslint-disable-next-line no-console - console.debug(`[render-trace] PageEditor #${_peRenderCount.current}`); - useEffect(() => { if (status.value === AUTH_STATUS.LOGGED_OUT) { triggerRecheck(); diff --git a/frontend/apps/artcraft/app/src/pages/PageScene/comps/Controls3D/Controls3D.tsx b/frontend/apps/artcraft/app/src/pages/PageScene/comps/Controls3D/Controls3D.tsx index 2bbd3acf77..6cb4b81db9 100644 --- a/frontend/apps/artcraft/app/src/pages/PageScene/comps/Controls3D/Controls3D.tsx +++ b/frontend/apps/artcraft/app/src/pages/PageScene/comps/Controls3D/Controls3D.tsx @@ -13,7 +13,7 @@ import { Button } from "@storyteller/ui-button"; import { Tooltip } from "@storyteller/ui-tooltip"; import { SettingsModal } from "@storyteller/ui-settings-modal"; import { EngineContext } from "../../contexts/EngineContext"; -import { useContext, useEffect, useRef, useState } from "react"; +import { useContext, useEffect, useState } from "react"; import { useShallow } from "zustand/shallow"; import { usePageSceneStore } from "../../PageSceneStore"; import { useTabStore } from "~/pages/Stores/TabState"; @@ -68,36 +68,6 @@ export const Controls3D = () => { const outlinerItemCount = usePageSceneStore((s) => s.outlinerItems.length); - // TEMP debug: render counter — see why this re-renders mid-click. - const renderRef = useRef({ count: 0, prev: null as Record | null }); - renderRef.current.count += 1; - const traced = { - assetModalVisible, - selectedMode, - transformSpace, - outlinerItemCount, - upload3DIsShowing, - uploadImageIsShowing, - uploadSplatIsShowing, - showEmptySceneTooltip, - isAddAssetPopoverOpen, - isSettingsModalOpen, - }; - const diff: Record = {}; - if (renderRef.current.prev) { - for (const k of Object.keys(traced) as Array) { - if (renderRef.current.prev[k] !== traced[k]) { - diff[k] = [renderRef.current.prev[k], traced[k]]; - } - } - } - // eslint-disable-next-line no-console - console.debug( - `[render-trace] Controls3D #${renderRef.current.count}`, - Object.keys(diff).length ? { diff } : { same: traced }, - ); - renderRef.current.prev = traced; - useEffect(() => { const isSceneEmpty = outlinerItemCount === 0 &&