From 3fb683185a1e756da3d641293ade07222c852ac0 Mon Sep 17 00:00:00 2001
From: bflatastic <bombayapirat@gmail.com>
Date: Thu, 4 Sep 2025 22:32:36 +0700
Subject: [PATCH] console errors and log spams fixed

---
 .../signaled/TopBar/AuthButtons.tsx           |  5 +---
 .../libs/components/modal/src/lib/modal.tsx   | 23 ++++++++++++++++++-
 2 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/frontend/apps/editor3d/app/src/components/signaled/TopBar/AuthButtons.tsx b/frontend/apps/editor3d/app/src/components/signaled/TopBar/AuthButtons.tsx
index 68e7b00472..960a7d84bd 100644
--- a/frontend/apps/editor3d/app/src/components/signaled/TopBar/AuthButtons.tsx
+++ b/frontend/apps/editor3d/app/src/components/signaled/TopBar/AuthButtons.tsx
@@ -11,12 +11,9 @@ export const AuthButtons = ({
 }) => {
   useSignals();
 
-  const { status, userInfo } = authentication;
-
-  console.log("Current State:", status.value);
+  const { status } = authentication;
 
   if (status.value === AUTH_STATUS.LOGGED_IN) {
-    console.log("SHOWING DROPDOWN");
     return null;
   } else {
     return (
diff --git a/frontend/libs/components/modal/src/lib/modal.tsx b/frontend/libs/components/modal/src/lib/modal.tsx
index 4eaf6cec4a..2c6248a072 100644
--- a/frontend/libs/components/modal/src/lib/modal.tsx
+++ b/frontend/libs/components/modal/src/lib/modal.tsx
@@ -12,6 +12,7 @@ import {
   faDownLeftAndUpRightToCenter,
 } from "@fortawesome/pro-solid-svg-icons";
 import { DomLevels } from "@storyteller/common";
+import { Root as VisuallyHidden } from "@radix-ui/react-visually-hidden";
 
 // ---------------------------------------------------------------------------
 // GLOBAL inert / aria-hidden stripper – applies once per page load
@@ -184,6 +185,8 @@ export const Modal = ({
   closeOnEsc = true,
   allowBackgroundInteraction = false,
   expandable = false,
+  accessibleTitle,
+  accessibleDescription,
 }: {
   isOpen: boolean;
   title?: ReactNode;
@@ -206,6 +209,8 @@ export const Modal = ({
   closeOnEsc?: boolean;
   allowBackgroundInteraction?: boolean;
   expandable?: boolean;
+  accessibleTitle?: string;
+  accessibleDescription?: string;
 }) => {
   // Draggable logic
   const [position, setPosition] = useState<{ x: number; y: number } | null>(
@@ -899,6 +904,9 @@ export const Modal = ({
                   <Dialog.Content
                     forceMount
                     asChild
+                    {...(accessibleDescription
+                      ? {}
+                      : ({ "aria-describedby": undefined } as any))}
                     onPointerDownOutside={(e) => {
                       if (!closeOnOutsideClick || allowBackgroundInteraction) {
                         e.preventDefault();
@@ -934,7 +942,14 @@ export const Modal = ({
                       }}
                     >
                       <div className="w-full h-full">
-                        {title && (
+                        {accessibleDescription && (
+                          <VisuallyHidden asChild>
+                            <Dialog.Description>
+                              {accessibleDescription}
+                            </Dialog.Description>
+                          </VisuallyHidden>
+                        )}
+                        {title ? (
                           <Dialog.Title
                             className={twMerge(
                               "mb-4 flex justify-between pb-0 text-xl font-bold text-white"
@@ -967,6 +982,12 @@ export const Modal = ({
                               )}
                             </>
                           </Dialog.Title>
+                        ) : (
+                          <VisuallyHidden asChild>
+                            <Dialog.Title>
+                              {accessibleTitle ?? "Dialog"}
+                            </Dialog.Title>
+                          </VisuallyHidden>
                         )}
                         <div className={`h-full`.trim()}>
                           {enhancedChildren}