From 3cfe0dfd07595a8e0396413019131fbdea822b27 Mon Sep 17 00:00:00 2001
From: Brandon Thomas <echelon@gmail.com>
Date: Tue, 6 May 2025 22:54:42 -0400
Subject: [PATCH] exit thread when window closes

---
 .../src/threads/sora_login_thread/sora_login_thread.rs      | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/crates/desktop/artcraft/src/threads/sora_login_thread/sora_login_thread.rs b/crates/desktop/artcraft/src/threads/sora_login_thread/sora_login_thread.rs
index 93457000e4..062561ad2b 100644
--- a/crates/desktop/artcraft/src/threads/sora_login_thread/sora_login_thread.rs
+++ b/crates/desktop/artcraft/src/threads/sora_login_thread/sora_login_thread.rs
@@ -37,15 +37,15 @@ pub async fn sora_login_thread(
   app: AppHandle,
   app_data_root: AppDataRoot,
   sora_creds_manager: SoraCredentialManager
-) -> ! {
+) {
   loop {
     info!(">>> SORA LOGIN THREAD <<<");
     
     let login_webview = match app.get_webview(LOGIN_WINDOW_NAME) {
       Some(webview) => webview,
       None => {
-        tokio::time::sleep(std::time::Duration::from_millis(2_000)).await;
-        continue;
+        info!("Exit sora login thread.");
+        return; // NB: Only exit if we don't have the webview.
       }
     };