From 1d3da065a291f520ca2d613a8cc83fa759e21982 Mon Sep 17 00:00:00 2001 From: Tanish Manku Date: Wed, 29 Apr 2026 09:42:38 -0700 Subject: [PATCH] PageScene: drop dead side-panel store fields sidePanelWidth, sidePanelVisible, dndSidePanelWidth and their setters are no longer read by any rendered component. Drop them from PageSceneStore and the lone setSidePanelWidth(340) call in PageEditor's mount effect. PreviewFrameImage's width calc no longer subtracts the (always-zero) panel width. --- .../app/src/pages/PageScene/PageEditor.tsx | 1 - .../app/src/pages/PageScene/PageSceneStore.ts | 12 ----------- .../PageScene/comps/PreviewFrameImage.tsx | 20 +++++++------------ 3 files changed, 7 insertions(+), 26 deletions(-) diff --git a/frontend/apps/artcraft/app/src/pages/PageScene/PageEditor.tsx b/frontend/apps/artcraft/app/src/pages/PageScene/PageEditor.tsx index 6e8954f516..e97ec0dd09 100644 --- a/frontend/apps/artcraft/app/src/pages/PageScene/PageEditor.tsx +++ b/frontend/apps/artcraft/app/src/pages/PageScene/PageEditor.tsx @@ -112,7 +112,6 @@ export const PageEditor = () => { }; useEffect(() => { - usePageSceneStore.getState().setSidePanelWidth(340); window.onbeforeunload = () => { return "You may have unsaved changes."; }; diff --git a/frontend/apps/artcraft/app/src/pages/PageScene/PageSceneStore.ts b/frontend/apps/artcraft/app/src/pages/PageScene/PageSceneStore.ts index 2e66fd255d..9ceb73a19d 100644 --- a/frontend/apps/artcraft/app/src/pages/PageScene/PageSceneStore.ts +++ b/frontend/apps/artcraft/app/src/pages/PageScene/PageSceneStore.ts @@ -99,9 +99,6 @@ interface PageSceneState { isPromptBoxFocused: boolean; // layout / panels - sidePanelWidth: number; - sidePanelVisible: boolean; - dndSidePanelWidth: number; assetModalVisible: boolean; assetModalVisibleDuringDrag: boolean; reopenAfterDrag: boolean; @@ -168,9 +165,6 @@ interface PageSceneState { setIsPromptBoxFocused: (focused: boolean) => void; // layout - setSidePanelWidth: (px: number) => void; - setSidePanelVisible: (visible: boolean) => void; - setDndSidePanelWidth: (px: number) => void; setAssetModalVisible: (visible: boolean) => void; setAssetModalVisibleDuringDrag: (visible: boolean) => void; setReopenAfterDrag: (reopen: boolean) => void; @@ -230,9 +224,6 @@ export const usePageSceneStore = create((set, get) => ({ hotkeyStatus: { disabled: false, disabledBy: DomLevels.NONE }, isPromptBoxFocused: false, - sidePanelWidth: 0, - sidePanelVisible: false, - dndSidePanelWidth: -1, assetModalVisible: false, assetModalVisibleDuringDrag: true, reopenAfterDrag: false, @@ -328,9 +319,6 @@ export const usePageSceneStore = create((set, get) => ({ setIsPromptBoxFocused: (focused) => set({ isPromptBoxFocused: focused }), // layout actions - setSidePanelWidth: (px) => set({ sidePanelWidth: px }), - setSidePanelVisible: (visible) => set({ sidePanelVisible: visible }), - setDndSidePanelWidth: (px) => set({ dndSidePanelWidth: px }), setAssetModalVisible: (visible) => set({ assetModalVisible: visible }), setAssetModalVisibleDuringDrag: (visible) => set({ assetModalVisibleDuringDrag: visible }), diff --git a/frontend/apps/artcraft/app/src/pages/PageScene/comps/PreviewFrameImage.tsx b/frontend/apps/artcraft/app/src/pages/PageScene/comps/PreviewFrameImage.tsx index 01b851440d..899ee05aae 100644 --- a/frontend/apps/artcraft/app/src/pages/PageScene/comps/PreviewFrameImage.tsx +++ b/frontend/apps/artcraft/app/src/pages/PageScene/comps/PreviewFrameImage.tsx @@ -8,24 +8,18 @@ import { usePageSceneStore } from "~/pages/PageScene/PageSceneStore"; export const PreviewFrameImage = () => { useSignals(); - const { editorState, previewSrc, sidePanelVisible, sidePanelWidth } = - usePageSceneStore( - useShallow((s) => ({ - editorState: s.editorState, - previewSrc: s.previewSrc, - sidePanelVisible: s.sidePanelVisible, - sidePanelWidth: s.sidePanelWidth, - })), - ); + const { editorState, previewSrc } = usePageSceneStore( + useShallow((s) => ({ + editorState: s.editorState, + previewSrc: s.previewSrc, + })), + ); if (editorState !== EditorStates.PREVIEW) { return null; } - const width = - pageWidth.value - - (sidePanelVisible ? sidePanelWidth : 0) - - 84; + const width = pageWidth.value - 84; const height = pageHeight.value - 56; if (previewSrc === "") {